You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue came up in the context of review #623 (comment). The trim_canopy routine uses this variable to check to see if there has been activity in a leaf layer for a given year:
This issue came up in the context of review #623 (comment). The
trim_canopy
routine uses this variable to check to see if there has been activity in a leaf layer for a given year:fates/biogeochem/EDPhysiologyMod.F90
Line 456 in 50e3c74
As noted by @rgknox this type of equivalence check against real numbers should be avoided. This type of check is also present in
DeallocateCohort
:fates/biogeochem/EDCohortDynamicsMod.F90
Lines 1349 to 1357 in 50e3c74
Given that this is slightly beyond the scope of #623, I'm breaking this out into a separate issue to be addressed later.
The text was updated successfully, but these errors were encountered: