Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The quadratic calculation of stomatal conductance in FATES #446

Closed
youwasha opened this issue Nov 29, 2018 · 10 comments
Closed

The quadratic calculation of stomatal conductance in FATES #446

youwasha opened this issue Nov 29, 2018 · 10 comments

Comments

@youwasha
Copy link

Hi all,

I'm a new one for the FATES model, I'm learning the FATES code right now. In FATES PlantRespPhotosynthMod, I only found an quadratic calculation to get stomatal conductance (gs) at each leaf layer (line 990-1000), Ball-Berry equation is just used as a comparison (line 1060-1067). I feel a little confused about why they use this quadratic equation.

I'll appreciate if someone can explain more about this. Thanks!

@dlebauer
Copy link

dlebauer commented Nov 29, 2018

for reference these are the lines in question ... https://github.com/NGEET/fates/blob/master/biogeophys/FatesPlantRespPhotosynthMod.F90#L1060

I am just learning about FATES/CLM but I suspect it has to do with the fact that CLM5.0 is using the Medlyn et al 2011 model of stomatal conductance instead of the Ball Berry model that was used through CLM 4.5 (see CLM 5.0 documentation). Medlyn et al add a 1/sqrt(D) parameter (eq 1 in the documentation; eq 11 in the original paper) that was not present in Ball Berry model; without going through the code it isn't clear if this is related...

@dlebauer
Copy link

Now I see that the code in line 1067, quadratic_f (aquad, bquad, cquad, r1, r2) is explained in eq 24 of the CLM 5.0 documentation under 'numerical implementation'.

Kudos to the team for clearly documenting the implementation!

@rosiealice
Copy link
Contributor

Indeed, the quadratic terms etc. pre-date the implementation of the Medlyn 2011 model in CLM5. It's worth noting that the FATES numerical implementation of photosynthesis dates from a little prior to the CLM4.5 release, and so is not all the same as the CLM5 technical documentation. There's some discussion by @walkeranthonyp on #443 about this too.

Note that FATES is still using Ball-Berry, rather than Medlyn, but it's not super difficult to implement Medlyn, if anyone wanted to do that. It only took a couple of lines and a couple of new parameters, and we already have the code from CLM5...

@youwasha
Copy link
Author

Thanks! @dlebauer @rosiealice , your comments are very helpful! Actually I'm trying to implement Medlyn equation into FATES. Thank you very much!

@rosiealice
Copy link
Contributor

Great! That would be a popular development I'm sure. Let us know if you need any more help navigating the terms. In CLM5 we were able to just change the basic gs calculation without modifying the operation of the solver. If you get the point of having some test code, then feel free to point us at it so we can collectively determine whether the CLM5 and FATES solutions differ in any 'interesting' ways. This part of the code can be quite opaque :/

@walkeranthonyp
Copy link

walkeranthonyp commented Dec 1, 2018

@youwasha UPDATE, I made a mistake describing the function here: it's a quadratic solve because the gs function is combined with the ficks law equation to get ci from cb, gs, and anet gs when the leaf boundary layer vapour pressure is unknown. You need to combine medlyn with ficks law to get the appropriate quadratic and then replace the ball berry derived quadratic parameters (i.e. a b c) with the medlyn derived parameters.

@youwasha
Copy link
Author

youwasha commented Dec 4, 2018

@walkeranthonyp Thank you so much, I'm doing just like what you said ;)
@rosiealice Thanks, I'll make a timely response if I meet some problems. I appreciate your kind help!

@serbinsh
Copy link

@youwasha I havent seen any updates on this since Dec 2014 but wanted to let you know there is a PR for adding Medlyn led by @Qianyuxuan now for FATES. It should be an option in the near future. Here is the PR: #608

@rgknox
Copy link
Contributor

rgknox commented Aug 17, 2020

closing as it seems the original question was answered, feel free to comment and re-open if more discussion necessary

@rgknox rgknox closed this as completed Aug 17, 2020
@youwasha
Copy link
Author

youwasha commented Aug 19, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants