New Test Request: thread change restart

[rgknox]

Summary of Issue:

A simulation should be able to be restarted from an intermediate time-point with a different thread layout than the original simulation, and complete to generate b4b output.

The test should complete within 10 minutes +-5.

The target test will likely be:

ERP_D_P15x2_Ld5.f10_f10

or an

ERP_D_P15x2_Ld3.f45_f45

I am leaning towards the Ld5.f10, as I think a few more days will give the possibility of more patch level fusion/creation to happen. I will probably bump up the run length to Ld9 if it completes in 10 minutes. Feel free to weigh in.

It is not expected that this test should pass right now. It is known that restarts do not pass thread-change layouts. It is hoped that this test should pass following restart refactors ( @rgknox ) which will be continued following refactors on history IO ( @bandre-ucar ).

Expected behavior and actual behavior:

Steps to reproduce the problem (should include create_newcase or create_test command along with any user_nl or xml changes):

What is the changeset ID of the code, and the machine you are using:

have you modified the code? If so, it must be committed and available for testing:

Screen output or output files showing the error message and context:

[rgknox]

I am planning on resolving this in my next PR:

master...rgknox:rgknox-warns-threadtest

Note I am dropping the ERS_Ld5.f10_f10 for edTest and replacing it with the ERP_D_P15x2_Ld5.f10_f10.

The ERS_Ld5.f10_f10 is kept for the noFire case and the auxilary tests.

Any comments or concerns? @bandre-ucar can you confirm I am doing in that comparison what I think I am doing?

[bandre-ucar]

For now, I'd prefer we keep the ERS test and add in the ERP test. They build on each other, an ERP test won't work if the equivalent ERS test doesn't work. Since the ERP test is new to us, it will help with debugging to have both as part of the standard suite for a while.

Also, please be sure that you use the manage_testlists tool in cime/scripts instead of hand editing the xml file. Syncing with the trunk generates unnecessary conflicts if we haven't used the tool.

[rgknox]

sure thing, I will just add that ERP test and leave the ERS test.

[rgknox]

Both ERP and ERP thread change tests are working, pending current PRs to fates-clm.
closing, see https://github.com/NGEET/fates-clm/issues/17 which is redundant