Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't zero out patch%fuel%frac_burnt() before we use it #1302

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Don't zero out patch%fuel%frac_burnt() before we use it #1302

wants to merge 6 commits into from

Conversation

adrifoster
Copy link
Contributor

Fixes #1301 by checking inside the TransLitterNewPatch for the type of disturbance instead of zero-ing outside of the subroutine.

Description:

Removed the lines in spawn_patches that zero-d the frac_burnt array too soon.
Added checks in TransLitterNewPatch to check for fire disturbance and a fire on the patch:
If no fire, new local variable frac_burnt set to 0.0, otherwise use patch%fuel%frac_burnt

Collaborators:

@glemieux

Expectation of Answer Changes:

Yes - should change answers because before we weren't burning any fuel

Checklist

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Test Results:

CTSM (or) E3SM (specify which) test hash-tag: ctsm5.3.012

CTSM (or) E3SM (specify which) baseline hash-tag: ctsm5.3.012

FATES baseline hash-tag: sci.1.80.4_api.37.0.0

Test Output:

Running tests now

glemieux
glemieux requested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@glemieux glemieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like moving the check into TransLitterNewPatch. That said, do we need to make sure that currentPatch%fuel%frac_burnt is set to zero at the end of spawn_patches or is that already handled elsewhere?

biogeochem/EDPatchDynamicsMod.F90 Outdated Show resolved Hide resolved
biogeochem/EDPatchDynamicsMod.F90 Outdated Show resolved Hide resolved
@adrifoster
Copy link
Contributor Author

I like moving the check into TransLitterNewPatch. That said, do we need to make sure that currentPatch%fuel%frac_burnt is set to zero at the end of spawn_patches or is that already handled elsewhere?

I added it to the top of the fire_model subroutine, where we zero other fire-related things. I don't know if this is the right place for it or not...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemieux glemieux glemieux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
FATES Pull Request Planning and Status
Status: Final Testing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dead fuels never actually consumed in fires
2 participants
@adrifoster @glemieux