Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMS_Lm3_D_Mmpi-serial.1x1_brazil.I2000Clm50FatesCruRsGs.izumi_intel.clm-FatesColdHydro fails when t_soisno is initialized to 272K instead of 274K #1163

Closed
olyson opened this issue Feb 22, 2024 · 1 comment · Fixed by #1164
Assignees

Comments

@olyson
Copy link

olyson commented Feb 22, 2024

A change is planned for the host model CTSM such that soil temperature for a cold start will be initialized to 272K instead of the current 274K. Purpose is to avoid locking in large amounts of deep soil carbon at high latitudes. Testing indicated a failure for SMS_Lm3_D_Mmpi-serial.1x1_brazil.I2000Clm50FatesCruRsGs.izumi_intel.clm-FatesColdHydro, caused by a divide by zero in FatesHydroWTFMod.F90 at this line:

psi = this%psi_sat*(th/this%th_sat)**(-this%beta)

where th is zero.
Please see ESCOMP/CTSM#2373 for more details.
Plan is that @rgknox has graciously agreed to provide a fix for this that @olyson will test in his current configuration. For the purposes of integrating the soil temperature change in CTSM, the test in question will be labeled as an ExpectedFail.

@olyson
Copy link
Author

olyson commented Feb 23, 2024

I have tested a fix provided by @rgknox and it resulted in the test passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants