Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clm bug 2082 - problem with ED history files on restarts #109

Closed
bandre-ucar opened this issue Aug 22, 2016 · 3 comments
Closed

clm bug 2082 - problem with ED history files on restarts #109

bandre-ucar opened this issue Aug 22, 2016 · 3 comments

Comments

@bandre-ucar
Copy link
Contributor

Summary of Issue:

Original bug: CLM - 2082

Need to test if this is still relevant.

Mariana Vertenstein 2014-11-02 14:26:06 MST
I have found the that comparing the first ED history files upon restarts - they are not bit-for-bit - even though the model remains bit-for-bit and the restart test passes. In particular - for clm4_5_1_r091. As an example - if I look at the case 

ERS_D_Mmpi-serial.1x1_brazil.ICLM45CNED.yellowstone_gnu.clm-edTest

and write 1d history files daily  - I will see that upon restart (which starts from the beginning of day 7)

clm2.h0.0001-01-08-00000.nc is different between the initial and restart runs in the following fields:

 RMS GPP                              2.2001E-04            NORMALIZED  3.1505E-02
 RMS LITTER_OUT                       4.2088E+00            NORMALIZED  2.8284E+00
 RMS NPP                              1.1212E-04            NORMALIZED  3.2232E-02

However clm2.h0.0001-01-12-00000.nc are identical between the initial and restart runs.

The same thing holds for clm4_5_1_r091 with the koven refactoring  changes I have brought in. However, in this case there are now only 2 fields that are different.

 RMS GPP                              2.2001E-04            NORMALIZED  3.1505E-02
 RMS NPP                              1.1212E-04            NORMALIZED  3.2232E-02

The LITTER_OUT problem is not longer there - but the other two are still persistent.

This should be fixed - but it also points to the need to compare history files upon restart as well.
@rgknox
Copy link
Contributor

rgknox commented Aug 22, 2016

So if I understand correctly, it looks as though the state variables that dictate the GPP and NPP diagnostics are restarting correctly, but for some reason the diagnostics on that first file are not correct.

So apparently it has something to do with how those history variables are initialized?

@bandre-ucar
Copy link
Contributor Author

That is my understanding. I was wondering if it had something to do with #24 or one of the other history bug fixes we've made. Best thing to do is test if the problem still exists.

@ckoven
Copy link
Contributor

ckoven commented Oct 10, 2017

this was solved a while ago; closing.

@ckoven ckoven closed this as completed Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants