Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_cohort() and the setting of canopy layer #1082

Open
rgknox opened this issue Sep 11, 2023 · 0 comments
Open

create_cohort() and the setting of canopy layer #1082

rgknox opened this issue Sep 11, 2023 · 0 comments

Comments

@rgknox
Copy link
Contributor

rgknox commented Sep 11, 2023

We pass in the canopy layer when we call create_cohort.

https://github.com/NGEET/fates/blob/sci.1.67.2_api.27.0.0/biogeochem/EDCohortDynamicsMod.F90#L160-L162

During cold start initializations, we pass a value of 1 (canopy). During recruitment, we pass in the value of patch%NCL_p which is the lowest canopy layer of the patch. Either way, if we are creating a new cohort, it seems its canopy layer is going to be an emergent property that shouldn't really be set until we run the canopy layering scheme anyway. I wonder if we can remove the argument and just set the canopy layer to uninitialized (ie a negative value).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ❕Todo
Development

No branches or pull requests

1 participant