Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image isn't saving in metadata #399

Closed
elliotBraem opened this issue Jun 17, 2024 · 3 comments · Fixed by #402
Closed

Image isn't saving in metadata #399

elliotBraem opened this issue Jun 17, 2024 · 3 comments · Fixed by #402
Assignees
Labels
bug Something isn't working
Milestone

Comments

@elliotBraem
Copy link
Contributor

elliotBraem commented Jun 17, 2024

Here is the full "Saving Data"

{
  "devs.near": {
    "project": {
      "build-gateway": {
        "": "{\"title\":\"Build Gateway\",\"description\":\"Building the site\",\"profileImage\":\"\",\"backgroundImage\":\"\",\"tags\":{\"community\":\"\",\"open-source\":\"\",\"dao\":\"\"},\"linktree\":{\"twitter\":\"NearBuilders\",\"github\":\"nearbuilders/gateway\",\"telegram\":\"builddao\",\"website\":\"https://www.nearbuilders.org\"},\"contributors\":[\"devs.near\"],\"tabs\":[\"overview\",\"tasks\",\"activity\"],\"projectAccountId\":\"builddao.near\",\"teamSize\":\"\",\"location\":\"\"}",
        "metadata": {
          "name": "Build Gateway",
          "description": "Building the site",
          "image": "",
          "backgroundImage": "",
          "tags": {
            "community": "",
            "open-source": "",
            "dao": ""
          },
          "linktree": {
            "twitter": "https://twitter.com/NearBuilders",
            "github": "https://github.com/nearbuilders/gateway",
            "telegram": "https://t.me/builddao",
            "website": "https://www.nearbuilders.org"
          }
        }
      }
    },
    "builddao.near": {
      "project": {
        "devs.near_project_build-gateway": ""
      }
    }
  }
}

And then it seems the commit is failing?

Screenshot 2024-06-16 at 10 23 45 PM
@elliotBraem elliotBraem added the bug Something isn't working label Jun 17, 2024
@elliotBraem elliotBraem added this to the v2 milestone Jun 17, 2024
@elliotBraem
Copy link
Contributor Author

With this ticket, let's go ahead and remove all metadata from the project data itself, aka no duplicate data.

Update code through out the app to reflect this, references metadata when needed.

@elliotBraem
Copy link
Contributor Author

This isn't happening when doing "Import from Potlock"

@Megha-Dev-19
Copy link
Collaborator

let's also add tests for creating project, I believe recent changes broke this functionality, it will help to avoid them in future.

@elliotBraem elliotBraem moved this to Backlog in Build DAO Gateway Jun 17, 2024
@elliotBraem elliotBraem self-assigned this Jun 17, 2024
@elliotBraem elliotBraem moved this from Backlog to In Progress in Build DAO Gateway Jun 18, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Build DAO Gateway Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants