Support for semicolon and new --insecure option #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`application/x-www-form-urlencoded`. With this method, I observed that caracters like semicolon are working. Added a new `--insecure` option to bypass SSL cert check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I suggest a small patch for 1 bug fix and 1 new feature.
BUG FIX
The bug is described here: #13
I juste changed payload to use
application/jsoncontent-type instead ofapplication/x-www-form-urlencoded. With this method, I observed thatcaracters like semicolon are working.
This is one of the 2 accepted format from what is described in Mattermost documentation: https://docs.mattermost.com/developer/webhooks-incoming.html
New feature
I added a new
--insecureoption to bypass SSL cert check. I had this issue where we used a self-signed certificate to test mattermost. This could be useful for other people.