From 2046f5f695cc42f3b6a1cbbe684f4cd13ebd6d24 Mon Sep 17 00:00:00 2001
From: Jonas Carlsen <jonas.carlsen@knowit.no>
Date: Wed, 10 Jul 2024 12:09:27 +0200
Subject: [PATCH] Make secondary button have a white background instead of
 being transparent

---
 packages/primitives/src/Button.tsx | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/packages/primitives/src/Button.tsx b/packages/primitives/src/Button.tsx
index 2e133a0ce4..44011d0303 100644
--- a/packages/primitives/src/Button.tsx
+++ b/packages/primitives/src/Button.tsx
@@ -12,6 +12,7 @@ import { RecipeVariantProps, css, cva } from "@ndla/styled-system/css";
 import { styled } from "@ndla/styled-system/jsx";
 import { JsxStyleProps, RecipeVariant } from "@ndla/styled-system/types";
 
+// TODO: Consider if any of the backgrounds should actually be transparent
 export const buttonBaseRecipe = cva({
   base: {
     display: "inline-flex",
@@ -68,7 +69,7 @@ export const buttonBaseRecipe = cva({
       },
       secondary: {
         color: "text.strong",
-        background: "transparent",
+        background: "surface.default",
         boxShadow: "inset 0 0 0 1px var(--shadow-color)",
         _hover: {
           background: "surface.actionSubtle.hover",