Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document test cases #291

Closed
F-said opened this issue Aug 25, 2021 · 3 comments
Closed

document test cases #291

F-said opened this issue Aug 25, 2021 · 3 comments
Labels
documentation improvements or additions to documentation

Comments

@F-said
Copy link
Contributor

F-said commented Aug 25, 2021

What needs documentation and what will each item entail?
Document failed tests and either fix tests or create issues for enhancements off of tests

@F-said F-said added the documentation improvements or additions to documentation label Aug 25, 2021
@F-said
Copy link
Contributor Author

F-said commented Aug 26, 2021

Notes

  • Test for commit 4544302
    • AKA Pre-release Serrano
  • Using conda environment built from environment.yml
  • Just running pytest w/o file-name gives a deprecation warning & pytest is latest version. discussed here

Filter_data

❌ Fails FR3. Must raise an exception when data being filtered is invalid. Check in the negative rather than the positive ("if data is NOT raw data" vs "if data is None, if data is NaN, if data is...")
image

Final_reject

✔️ Passes all test-cases.
image

Ica_raw

❌ Fails IR3. Error in code
image

Ident_badchans

✔️ Passes all test-cases. NOTE Test impacted by dev-fix-lastReleaseUnplanned, need to merge in branch to see new fix
image

Interp_data

✔️Passes all test-cases.
image

Reref_data

❌ Fails RR3. Needs to throw an exception.
image

Segment data

❌ Fails S3. Needs to throw an exception.
image

Select data

❌ Fails a lot, needs a separate issue to break down fixes.
image

@F-said
Copy link
Contributor Author

F-said commented Aug 27, 2021

  • Create param to halt pipeline on error
  • Create param to skip already processed subj, run, tasks

@F-said
Copy link
Contributor Author

F-said commented Sep 2, 2021

Moving issues and closing

@F-said F-said closed this as completed Sep 2, 2021
@F-said F-said reopened this Sep 3, 2021
@F-said F-said closed this as completed Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant