Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test stability of pepper for contributors before 1st release #281

Closed
F-said opened this issue Aug 23, 2021 · 7 comments
Closed

Test stability of pepper for contributors before 1st release #281

F-said opened this issue Aug 23, 2021 · 7 comments

Comments

@F-said
Copy link
Contributor

F-said commented Aug 23, 2021

Describe the feature to be tested
Before creating a discrete release its crucial to test the stability.

Which tests need to be made for the feature
This involves running all pytests over

  • local (using conda)
  • local (using dockerfile)
  • hpc (using singularity)

Running regular pipeline over

  • local (using conda)
  • local (using dockerfile)
  • hpc (using singularity)

As well as testing

  • dockerfile builds
  • conda environment builds
  • singularity recipe builds

And no new bugs are discovered.

This should be an automated process using Github actions eventually. Will record protocol and automate using Jenkins or Actions.

@F-said F-said changed the title Test stability of pepper before 1st release Test stability of pepper for contributors before 1st release Aug 23, 2021
@F-said
Copy link
Contributor Author

F-said commented Aug 24, 2021

Dockerfile test

Notes

  • Test for commit 4544302
    • AKA Pre-release Szegedi
  • changed "load_data:root" to "/projects/CMI/rawdata"
  • changed "output_data"root" to "/projects/CMI"
  • created data volume using docker README to mount PEPPER code and data
  • activated conda environment w/in container

in progress, will attach screenshots

Build

✔️Succeeded. Image builds w/o error
image

Pytest

Tested the following modules for successful run (all packages load):

  • test_filter_data.py
    ✔️Succeeded. test fails same as local
    image
  • test_final_reject.py
    ✔️Succeeded. test succeeds same as local
    image
  • test_ica_raw.py
    ✔️Succeeded. test fails same as local
    image
  • test_ident_badchans.py
    ✔️Succeeded. test fails same as local
    image
  • test_interp_data.py
    ✔️Succeeded. test succeeds same as local
    image
  • test_reref_data.py
    ✔️Succeeded. test fails same as local
    image
  • test_segment_data.py
    ✔️Succeeded. test fails same as local
    image
  • test_select_data.py
    ✔️Succeeded. test fails same as local
    image

Run.py

Tested the following modules for a successful run (all packages load):

  • run.py
    ❌Failed. No permission to write, even in /projects
    image

Data

Tested the following modules for a successful run (all packages load):

  • load.py

    • load_params()
      ✔️Succeeded. loads user_params
      image
    • load_files()
      ✔️Succeeded. loads files from user_params
      image
  • write.py

    • write_template_params()
      ✔️Succeeded. returns default user_params
      image
    • write_eeg_data()
      ❌Failed. No permission to write, even in /projects
      image
    • read_dict_to_json()
      ❌Failed. No permission to write, even in /projects
      image

Preprocess

Tested the following modules for a successful run (all packages load):

  • preprocess.py
    • filter()
      ✔️Succeeded.
      image
    • ident_badchans_raw()
      ✔️Succeeded.
      image
    • ica_raw()
      ✔️Succeeded.
      image
    • segment_data()
      ✔️Succeeded.
      image
    • final_reject_epoch()
      ✔️Succeeded.
      image
    • interpolate_data()
      ✔️Succeeded.
      image
    • reref_raw()
      ✔️Succeeded.
      image

@F-said
Copy link
Contributor Author

F-said commented Aug 25, 2021

Singularity Container Test

Notes

  • Test for commit 4544302
    • AKA Pre-release Szegedi

Pytest

Tested the following modules for successful run (all packages load):

  • test_filter_data.py
  • test_final_reject.py
  • test_ica_raw.py
  • test_ident_badchans.py
  • test_interp_data.py
  • test_reref_data.py
  • test_segment_data.py
  • test_select_data.py

Run.py

Tested the following modules for successful run (all packages load):

  • run.py

Data

Tested the following modules for successful run (all packages load):

  • load.py
  • write.py

Preprocess

Tested the following modules for successful run (all packages load):

  • preprocess.py

@F-said
Copy link
Contributor Author

F-said commented Aug 25, 2021

Conda Test

Notes

  • Test for commit 4544302
    • AKA Pre-release Szegedi
  • Built env using anaconda navigator

Pytest

Tested the following modules for successful run (all packages load):

  • test_filter_data.py
    ✔️ Builds and runs
    image
  • test_final_reject.py
    ✔️ Builds and runs
    image
  • test_ica_raw.py
    ✔️ Builds and runs
    image
  • test_ident_badchans.py
    ✔️Builds and runs
    image
  • test_interp_data.py
    ✔️Builds and runs
    image
  • test_reref_data.py
    ✔️Builds and runs
    image
  • test_segment_data.py
    ✔️Builds and runs
    image
  • test_select_data.py
    ✔️Builds and runs
    image

Run.py

Tested the following modules for a successful run (all packages load):

  • run.py
    ✔️Builds and runs
    image

Data

Tested the following modules for a successful run (all packages load):

  • load.py

    • load_params()
      ✔️Builds and runs
      image
    • load_files()
      ✔️Builds and runs
      image
  • write.py
    ✔️Builds and runs

Preprocess

Tested the following modules for a successful run (all packages load):

  • preprocess.py
    • filter()
      ✔️Succeeded.
      image
    • ident_badchans_raw()
      ✔️Succeeded.
      image
    • ica_raw()
      ✔️Succeeded.
      image
    • segment_data()
      ✔️Succeeded.
      image
    • final_reject_epoch()
      ✔️Succeeded.
      image
    • interpolate_data()
      ✔️Succeeded.
      image
    • reref_raw()
      ✔️Succeeded.
      image

@F-said
Copy link
Contributor Author

F-said commented Aug 27, 2021

Revisit bind vs mount in closed discussion

@F-said
Copy link
Contributor Author

F-said commented Sep 2, 2021

Resolved docker error via #306

@F-said
Copy link
Contributor Author

F-said commented Sep 2, 2021

Removing singularity stability test and moving to diff issue for closure

@F-said F-said closed this as completed Sep 2, 2021
@F-said
Copy link
Contributor Author

F-said commented Sep 9, 2021

Resolved singularity stability #307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant