fix(search): added aria-label attributes

Closes #1134, #1133, #1136
NCI-GDC · Sep 1, 2015 · 65a74a9 · 65a74a9
1 parent b6de0f7
commit 65a74a9
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 11 deletions.
diff --git a/app/scripts/cart/templates/add-to-cart-button-single.html b/app/scripts/cart/templates/add-to-cart-button-single.html
@@ -1,10 +1,12 @@
 <button
-  data-tooltip-popup-delay=1000 data-tooltip="Add to Cart" 
+  aria-label="Add to Cart"
+  data-tooltip-popup-delay=1000 data-tooltip="Add to Cart"
   data-ng-if="!CartService.isInCart(file.file_id)" type="button" class="btn btn-default"
         data-ng-click="addToCart([file])">
   <i class="fa fa-shopping-cart"></i>
-<!-- this need to connect or we get a &nbsp in the markup -->    
+<!-- this need to connect or we get a &nbsp in the markup -->
 </button><button
+  aria-label="Remove from Cart"
   data-tooltip-popup-delay=1000 data-tooltip="Remove from Cart"
   data-ng-if="CartService.isInCart(file.file_id)" type="button" class="btn btn-success"
         data-ng-click="removeFromCart([file])">

diff --git a/app/scripts/components/tables/templates/arrange-columns.html b/app/scripts/components/tables/templates/arrange-columns.html
@@ -3,7 +3,8 @@
             dropdown-toggle aria-expanded="false"
             data-tooltip-popup-delay=1000
             data-tooltip="Arrange Columns"
-            data-tooltip-append-to-body="true">
+            data-tooltip-append-to-body="true"
+            aria-label="Arrange Columns">
         <span class="fa fa-bars"></span>
     </button>
 
@@ -32,7 +33,7 @@
               <i class="fa fa-stack fa-{{item.hidden ? 'square-o' : 'check-square-o'}}" data-ng-click="toggleVisibility(item)"></i>
               {{ item.name | ellipsicate:18 }}
               <i class="pull-right text-right fa fa-bars fa-stack"
-                as-sortable-item-handle 
+                as-sortable-item-handle
                 data-ng-class="{ 'fa-disabled': search.name }"></i>
           </li>
          </ul>

diff --git a/app/scripts/components/tables/templates/sort-table.html b/app/scripts/components/tables/templates/sort-table.html
@@ -1,9 +1,10 @@
 <div class="btn-group" data-dropdown auto-close="outsideClick">
   <button type="button" class="btn btn-default dropdown-toggle"
-          data-tooltip="Sort Table" 
-          data-tooltip-popup-delay=1000 
-          data-tooltip-append-to-body="true" 
-          dropdown-toggle aria-expanded="false">
+          data-tooltip="Sort Table"
+          data-tooltip-popup-delay=1000
+          data-tooltip-append-to-body="true"
+          dropdown-toggle aria-expanded="false"
+          aria-label="Sort Table">
     <span class="fa fa-sort-alpha-asc"></span>
   </button>
 
@@ -13,7 +14,7 @@
         <i class="fa fa-{{item.sort ? 'check-square-o' : 'square-o'}} fa-stack" ng-click="tsc.toggleSorting(item)"></i>
         <span>{{ item.name | translate }}</span>
         <span class="pull-right text-right" data-ng-if="item.sort">
-          
+
           <i class="fa fa-sort-alpha-asc"></i>
           <input type="radio" aria-label="Sort Data Ascending" value="asc"
               data-ng-model="item.order" data-ng-change="tsc.updateSorting()"

diff --git a/app/scripts/reports/templates/reports.html b/app/scripts/reports/templates/reports.html
@@ -1,6 +1,6 @@
 <div class="container-fluid full-page entity">
   <h1 data-scroll-fix=85>
-    <img src="/images/icon-reports-large.png" width="30" height="30"/>
+    <img alt="Data Download Statistics Icon" src="/images/icon-reports-large.png" width="30" height="30"/>
     Data Download Statistics
   </h1>
 
@@ -11,7 +11,7 @@ <h1 data-scroll-fix=85>
         includes information about the total number and size of downloaded files categorized at project, data and user
         access levels.
       </p>
-    
+
       <p class="pull-right">
         <reports-export-table data-text="Export Report" data-size="{{ rsc.reports.pagination.total }}"
                         data-endpoint="reports/data-download-statistics"