fix(components): handle empty fields in gql/facets

Closes #2126, #2124
NCI-GDC · Apr 26, 2016 · 1078fae · 1078fae
1 parent 3056b21
commit 1078fae
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/app/scripts/components/facets/facets.controllers.ts b/app/scripts/components/facets/facets.controllers.ts
@@ -515,6 +515,7 @@ module ngApp.components.facets.controllers {
 
     addFacet() {
       var selectedField = this.$scope.filteredFields[this.selectedIndex];
+      if (!selectedField) return;
       var fileOptions = {
         fields: [],
         expand: [],

diff --git a/app/scripts/components/gql/gql.filters.ts b/app/scripts/components/gql/gql.filters.ts
@@ -3,7 +3,7 @@ module ngApp.components.gql.filters {
   class GqlHighlight {
     constructor() {
       return function (value: string, query: string): string {
-        return value.replace(query, '<strong>' + query + '</strong>');
+        return (value || '').replace(query, '<strong>' + query + '</strong>');
       };
     }
   }

diff --git a/app/scripts/components/gql/module.ts b/app/scripts/components/gql/module.ts
@@ -151,15 +151,15 @@ module ngApp.components.gql {
       if (parts.docType === "files") {
         return this.FilesService.getFiles(params)
           .then((fs: IFiles): IDdItem[] => {
-            var f: IFacet = fs.aggregations[parts.facet];
+            var f: IFacet = (fs.aggregations || {})[parts.facet] || [];
             return _.map(f.buckets, (b) => {
               return {field: b.key, full: b.key};
             });
           });
       } else {
         return this.ParticipantsService.getParticipants(params)
           .then((fs: IParticipants): IDdItem[] => {
-            var f: IFacet = fs.aggregations[parts.facet];
+            var f: IFacet = (fs.aggregations || {})[parts.facet] || [];
             return _.map(f.buckets, (b) => {
               return {field: b.key, full: b.key};
             });