fix(files): Size filter handles undefined val.

Closes #835
NCI-GDC · May 27, 2015 · 0509a52 · 0509a52
1 parent 4777af5
commit 0509a52
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/app/scripts/components/ui/file/file.filters.ts b/app/scripts/components/ui/file/file.filters.ts
@@ -13,7 +13,7 @@ module ngApp.components.ui.file {
 
     constructor() {
       return function (val: number) {
-        var formattedVal: string;
+        var formattedVal: string = "0 B";
 
         if (val >= FileSize.BYTES_TB_LIMIT) {
           formattedVal = (val / FileSize.BYTES_PB).toFixed(2) + " PB";
@@ -25,7 +25,7 @@ module ngApp.components.ui.file {
           formattedVal = (val / FileSize.BYTES_MB).toFixed(0) + " MB";
         } else if (val >= FileSize.BYTES_KB) {
           formattedVal = (val / FileSize.BYTES_KB).toFixed(0) + " KB";
-        } else {
+        } else if (val) {
           formattedVal = val + " B";
         }
 

diff --git a/app/scripts/components/ui/file/tests/sizefilter.tests.js b/app/scripts/components/ui/file/tests/sizefilter.tests.js
@@ -63,4 +63,10 @@ describe("File Size Filter:", function () {
     expect(formattedSize).to.equal("999 B");
   }));
 
+  it("should filter 0 B when no value given", inject(function ($filter) {
+    var formattedSize = "0 B";
+    formattedSize = $filter("size")();
+    expect(formattedSize).to.equal("0 B");
+  }));
+
 });