Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix in FA, HWRF RRTMG and HWRF SAS #45

Merged
merged 3 commits into from
May 6, 2020
Merged

Bug fix in FA, HWRF RRTMG and HWRF SAS #45

merged 3 commits into from
May 6, 2020

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented May 5, 2020 •
edited
Loading

Update submodule pointer for fv3atm and date tag for regression test baseline in tests/rt.sh. See description in NCAR/ccpp-physics#447.

Associated PRs:

NCAR/ccpp-physics#447
NCAR/fv3atm#47
#45

For regression testing information, see below.

This was referenced May 5, 2020
Merged
Merged
@climbfuji climbfuji marked this pull request as ready for review May 5, 2020 02:01
@climbfuji climbfuji requested a review from mzhangw May 5, 2020 02:02
@climbfuji
Copy link
Collaborator Author

Regression testing on hera.intel against existing baseline using rt.conf: the following tests fail as expected in both REPRO and PROD mode:

fv3_ccpp_gfdlmp_hwrfsas
fv3_ccpp_regional_c768_FA
fv3_ccpp_regional_c768_HWRF_PBL
fv3_ccpp_regional_c768_FA_HWRF_RRTMG

rt_hera_intel_against_old_baseline.log
rt_hera_intel_against_old_baseline_fail_test.log

@climbfuji
Copy link
Collaborator Author

Creating new baseline and verifying against it (after moving to final location) on hera.intel: all tests pass

rt_hera_intel_create.log
rt_hera_intel_verify.log

@climbfuji
Copy link
Collaborator Author

Creating new baseline and verifying against it (after moving to final location) on cheyenne.gnu: all tests pass

rt_cheyenne_gnu_create.log
rt_cheyenne_gnu_verify.log

@climbfuji
Copy link
Collaborator Author

climbfuji commented May 5, 2020 •
edited
Loading

Creating new baseline and verifying against it (after moving to final location) on cheyenne.intel: "create" all tests pass, "verify" the following tests fail in both REPRO and PROD mode (known issue that is worked on) - ok for this commit.

fv3_ccpp_regional_c768_FA
fv3_ccpp_regional_c768_HWRF_PBL
fv3_ccpp_regional_c768_FA_HWRF_RRTMG

rt_cheyenne_intel_create.log

rt_cheyenne_intel_verify.log
rt_cheyenne_intel_verify_fail_test.log

@climbfuji climbfuji merged commit 76e1bf9 into NCAR:dtc/hwrf-physics May 6, 2020
@climbfuji climbfuji mentioned this pull request Jun 7, 2020
Closed
SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request Mar 16, 2023
@grantfirl
Combo for ccpp/physics NCAR#41 and NCAR#45 and ccpp/framework submodu…
018e396 
…le pointer update for ufs-community#462 (ufs-community#1654)

* update FV3 submodule and .gitmodules for testing of 20230313_combo

* turn off cpld_control_p8_faster cheyenne
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantfirl grantfirl Awaiting requested review from grantfirl grantfirl is a code owner

@llpcarson llpcarson Awaiting requested review from llpcarson

@mzhangw mzhangw Awaiting requested review from mzhangw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@climbfuji