Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master: regain bit-for-bit identical results between IPD and CCPP for coupled model runs #417

Merged
merged 7 commits into from
Mar 27, 2020

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Mar 24, 2020

This PR provides updates of the CCPP code to regain bit-for-bit identical results for coupled model runs.

The bit-for-bit match was lost over two previous commits to IPD and CCPP:

ccpp-physics:
#378
#398

fv3atm:
NOAA-EMC/fv3atm#44
NOAA-EMC/fv3atm#66 (this PR doesn't show as merged, because it was pulled into NCAR dtc/develop first and then brought back to EMC develop)

Besides the absolutely necessary changes to obtain bit-for-bit identical results between IPD and CCPP in the coupled model configuration, an attempt was made to make the code look as close as possible and to initialize variables in CCPP as in IPD (even though not strictly required) so that future comparisons will be easier. This includes removing the interstitial arrays for seaice coupling and using the regular arrays (that are part of the Coupling DDT), similar to what is done in NOAA-EMC/fv3atm#86.

This PR also contains @pjpegion's bug fixes for precipitation in the coupled model configuration (#416).

Associated PRs:
#417
NOAA-EMC/fv3atm#86
ufs-community/ufs-weather-model#91

For regression testing information, see ufs-community/ufs-weather-model#91.

Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, but my brain is tied in knots with the fractional landmask stuff. As mentioned, it would be wonderful to have some documentation of how this all works between the various CCPP schemes.

@climbfuji climbfuji merged commit efb68b5 into NCAR:master Mar 27, 2020
@climbfuji climbfuji deleted the coupled_model_ipd_ccpp_b4b branch June 27, 2022 03:10
hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this pull request Aug 3, 2022
…uplicate symbols error on macOS; ccpp-physics: cleanup CCPP cmake flags part 1; contains "fix the number of 2d fields nsfcprop2d" (NCAR#419) (NCAR#417)

- Fixes a bug inGFS_diagnostics.F90 that registered several stochastic variables as diagnostic output even though th arrays are not allocated if the corresponding stochastic option is turned off
- Fixes a problem that led to a "duplicate symbols" error on macOS with Intel by removing files from ccpp/CMakeLists.txt that get added automatically by CCPP
- Updates the submodule pointer for ccpp-physics for the changes described in Cleanup CCPP cmake flags part 1, remove extra logic that reduces optimization for radiation_aerosols.f, update CODEOWNERS, update README.md NCAR#773
- Contains the changes in fix the number of 2d fields nsfcprop2d NCAR#419 from @HelinWei-NOAA
- Updates the submodule pointer for GFDL_atmos_cubed_sphere to include latest JEDI control changes (contributed by @mark-a-potts)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants