nifa and nwfa not as tracers, but can be outputted and be seen by Thompson MP

[climbfuji]

From @AnningCheng-NOAA:

I have added mraerosol similar to ltaerosol by setting ltaerosol as false and mraerosol as true, and nifa and nwfa are calculated and not as tracers. but when ltaerosol is false, nifa and nwfa cannot be seen by mp_thompson because they are optional variables. My question is how to setting nifa and nwfa as non-optional when ltaerosol is false? The other issue is how to put these two variables in Statein(nb)%qgrs? so they can be outputted properly

I have performed an experiment by changing nifa and nwfa from optional to nonoptional in mp_thompson.F90, but receive an compilation err as "Exception: Variable mass_number_concentration_of_hygroscopic_aerosols in mp_thompson/mp_thompson_init is not an optional argument, but listed as such in the CCPP_prebuild config". Where is the CCPP_prebuild config and how to make changes on it?

I think you can achieve this, but one question I have before I can give you an answer is whether you are also using the nwfa2d and nifa2d surface emission rates. With using I mean is there any place anywhere in the code that tries to read from or write to these arrays.

I assume there is, because both get passed from mp_thompson_run to mp_gt_driver if ltaerosol is true - how does that work for mraerosol?

[AnningCheng-NOAA]

Dom, Merra2 aerosol aware does not need nwfa2d and nifa2d. As optional variables, they do not need to be passed in mp_gt_driver when mraerosol is true. We need to turn the reading and writing of nifa2d and nwfa2d off too.

…

On Mon, Sep 27, 2021 at 6:32 PM Dom Heinzeller ***@***.***> wrote: From @AnningCheng-NOAA <https://github.com/AnningCheng-NOAA>: I have added mraerosol similar to ltaerosol by setting ltaerosol as false and mraerosol as true, and nifa and nwfa are calculated and not as tracers. but when ltaerosol is false, nifa and nwfa cannot be seen by mp_thompson because they are optional variables. My question is how to setting nifa and nwfa as non-optional when ltaerosol is false? The other issue is how to put these two variables in Statein(nb)%qgrs? so they can be outputted properly I have performed an experiment by changing nifa and nwfa from optional to nonoptional in mp_thompson.F90, but receive an compilation err as "Exception: Variable mass_number_concentration_of_hygroscopic_aerosols in mp_thompson/mp_thompson_init is not an optional argument, but listed as such in the CCPP_prebuild config". Where is the CCPP_prebuild config and how to make changes on it? I think you can achieve this, but one question I have before I can give you an answer is whether you are also using the nwfa2d and nifa2d surface emission rates. With using I mean is there any place anywhere in the code that tries to read from or write to these arrays. I assume there is, because both get passed from mp_thompson_run to mp_gt_driver if ltaerosol is true - how does that work for mraerosol? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#746>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALQPMIMSY3ELPEJKLQZAFGDUEDWG7ANCNFSM5E3UAFSQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[MicroTed]

" ... is not an optional argument, but listed as such in the CCPP_prebuild config"

For this message, check the settings in the mp_thompson.meta file and whether the input variable has the trait "optional" = T or F. (I think you want F?)

If you need the 2d arrays (nwfa2d,nifa2d) when ltaerosol=F, also update the "active" trait logic for these in typedefs.meta.

Hope that helps.

[climbfuji]

Dom, Merra2 aerosol aware does not need nwfa2d and nifa2d. As optional variables, they do not need to be passed in mp_gt_driver when mraerosol is true. We need to turn the reading and writing of nifa2d and nwfa2d off too.
…

Anning, I believe the easiest solution would be to simply allocate nifa2d and nwfa2d as a dummy array with only one element, and set it to NaN. Then modify the logic in the I/O layer of fv3atm to not write out those arrays when mraerosol is true. In ccpp-physics, we do the same. Just write the logic such that nifa2d and nwfa2d are never read or written when mraerosol is true. No need to change any of the optional argument logic for now. We (CCPP developers) can take care of that when we remove the support for optional arguments from CCPP altogether (which is on our todo list anyway).

The only other thing I would add in mp_thompson_init is a consistency check that either mraerosol or ltaerosol or none of them is true, but not both of them at the same time.

[AnningCheng-NOAA]

Dom, great to know. Where is the code that read and write nifa2d and nwfa2d? I have difficulty locating the piece of code. The current version nifa and nwfa are optional variables. When they are not read in the field-table, the cap to call mp_thompson does not include nifa and nwfa. Is there any way to change the framework to include nifa and nwfa in the current version or we have to wait for the new version that removes the support for optional arguments? Lastly, when will the new version of the UFS that removes optional variables be available? Thank you!

…

On Mon, Oct 4, 2021 at 3:02 PM Dom Heinzeller ***@***.***> wrote: Dom, Merra2 aerosol aware does not need nwfa2d and nifa2d. As optional variables, they do not need to be passed in mp_gt_driver when mraerosol is true. We need to turn the reading and writing of nifa2d and nwfa2d off too. … <#m_2463767692776519034_> Anning, I believe the easiest solution would be to simply allocate nifa2d and nwfa2d as a dummy array with only one element, and set it to NaN. Then modify the logic in the I/O layer of fv3atm to not write out those arrays when mraerosol is true. In ccpp-physics, we do the same. Just write the logic such that nifa2d and nwfa2d are never read or written when mraerosol is true. No need to change any of the optional argument logic for now. We (CCPP developers) can take care of that when we remove the support for optional arguments from CCPP altogether (which is on our todo list anyway). The only other thing I would add in mp_thompson_init is a consistency check that either mraerosol or ltaerosol or none of them is true, but not both of them at the same time. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#746 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALQPMIKYYQII33UILEU5WILUFH22RANCNFSM5E3UAFSQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[climbfuji]

Anning, if you point me to your branches of fv3atm and ccpp-physics on github, then I can check out the code, make the necessary adjustments and send you a pull request to merge. This way you can see what I changed, and I can go over the changes with you line by line.

…

On Oct 4, 2021, at 1:44 PM, AnningCheng-NOAA ***@***.***> wrote: Dom, great to know. Where is the code that read and write nifa2d and nwfa2d? I have difficulty locating the piece of code. The current version nifa and nwfa are optional variables. When they are not read in the field-table, the cap to call mp_thompson does not include nifa and nwfa. Is there any way to change the framework to include nifa and nwfa in the current version or we have to wait for the new version that removes the support for optional arguments? Lastly, when will the new version of the UFS that removes optional variables be available? Thank you! On Mon, Oct 4, 2021 at 3:02 PM Dom Heinzeller ***@***.***> wrote: > Dom, Merra2 aerosol aware does not need nwfa2d and nifa2d. As optional > variables, they do not need to be passed in mp_gt_driver when mraerosol is > true. We need to turn the reading and writing of nifa2d and nwfa2d off too. > … <#m_2463767692776519034_> > > Anning, I believe the easiest solution would be to simply allocate nifa2d > and nwfa2d as a dummy array with only one element, and set it to NaN. Then > modify the logic in the I/O layer of fv3atm to not write out those arrays > when mraerosol is true. In ccpp-physics, we do the same. Just write the > logic such that nifa2d and nwfa2d are never read or written when mraerosol > is true. No need to change any of the optional argument logic for now. We > (CCPP developers) can take care of that when we remove the support for > optional arguments from CCPP altogether (which is on our todo list anyway). > > The only other thing I would add in mp_thompson_init is a consistency > check that either mraerosol or ltaerosol or none of them is true, but not > both of them at the same time. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#746 (reply in thread)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ALQPMIKYYQII33UILEU5WILUFH22RANCNFSM5E3UAFSQ> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#746 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RKSIPXOCZ3FAFL4SPTUFH7ZNANCNFSM5E3UAFSQ>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[AnningCheng-NOAA]

Hi, Dom: That is great. My ccpp/physics branch: https://github.com/AnningCheng-NOAA/ccpp-physics my fv3atm branch: /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/FV3 Please let me know when you are done, Thank you! Anning On Mon, Oct 4, 2021 at 3:53 PM Dom Heinzeller ***@***.***> wrote:

…

Anning, if you point me to your branches of fv3atm and ccpp-physics on github, then I can check out the code, make the necessary adjustments and send you a pull request to merge. This way you can see what I changed, and I can go over the changes with you line by line. > On Oct 4, 2021, at 1:44 PM, AnningCheng-NOAA ***@***.***> wrote: > > > Dom, > great to know. > Where is the code that read and write nifa2d and nwfa2d? I have difficulty > locating the piece of code. > > The current version nifa and nwfa are optional variables. When they are not > read in the field-table, the cap to call mp_thompson does not include nifa > and nwfa. Is there any way to change the framework to include nifa and > nwfa in the current version or we have to wait for the new version that > removes the support for optional arguments? > > Lastly, when will the new version of the UFS that removes optional > variables be available? > > Thank you! > > On Mon, Oct 4, 2021 at 3:02 PM Dom Heinzeller ***@***.***> > wrote: > > > Dom, Merra2 aerosol aware does not need nwfa2d and nifa2d. As optional > > variables, they do not need to be passed in mp_gt_driver when mraerosol is > > true. We need to turn the reading and writing of nifa2d and nwfa2d off too. > > … <#m_2463767692776519034_> > > > > Anning, I believe the easiest solution would be to simply allocate nifa2d > > and nwfa2d as a dummy array with only one element, and set it to NaN. Then > > modify the logic in the I/O layer of fv3atm to not write out those arrays > > when mraerosol is true. In ccpp-physics, we do the same. Just write the > > logic such that nifa2d and nwfa2d are never read or written when mraerosol > > is true. No need to change any of the optional argument logic for now. We > > (CCPP developers) can take care of that when we remove the support for > > optional arguments from CCPP altogether (which is on our todo list anyway). > > > > The only other thing I would add in mp_thompson_init is a consistency > > check that either mraerosol or ltaerosol or none of them is true, but not > > both of them at the same time. > > > > — > > You are receiving this because you were mentioned. > > Reply to this email directly, view it on GitHub > > < #746 (reply in thread) >, > > or unsubscribe > > < https://github.com/notifications/unsubscribe-auth/ALQPMIKYYQII33UILEU5WILUFH22RANCNFSM5E3UAFSQ > > > . > > Triage notifications on the go with GitHub Mobile for iOS > > < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 > > > or Android > > < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub >. > > > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub < #746 (comment)>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AB5C2RKSIPXOCZ3FAFL4SPTUFH7ZNANCNFSM5E3UAFSQ >. > Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#746 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALQPMIORRZLCJYFWZRY2R2TUFIA33ANCNFSM5E3UAFSQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[AnningCheng-NOAA]

here is my fv3atm branch: https://github.com/AnningCheng-NOAA/fv3atm. I copied the physical directory last time On Mon, Oct 4, 2021 at 3:59 PM Anning Cheng - NOAA Affiliate < ***@***.***> wrote:

…

Hi, Dom: That is great. My ccpp/physics branch: https://github.com/AnningCheng-NOAA/ccpp-physics my fv3atm branch: /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/FV3 Please let me know when you are done, Thank you! Anning On Mon, Oct 4, 2021 at 3:53 PM Dom Heinzeller ***@***.***> wrote: > Anning, if you point me to your branches of fv3atm and ccpp-physics on > github, then I can check out the code, make the necessary adjustments and > send you a pull request to merge. This way you can see what I changed, and > I can go over the changes with you line by line. > > > On Oct 4, 2021, at 1:44 PM, AnningCheng-NOAA ***@***.***> wrote: > > > > > > Dom, > > great to know. > > Where is the code that read and write nifa2d and nwfa2d? I have > difficulty > > locating the piece of code. > > > > The current version nifa and nwfa are optional variables. When they are > not > > read in the field-table, the cap to call mp_thompson does not include > nifa > > and nwfa. Is there any way to change the framework to include nifa and > > nwfa in the current version or we have to wait for the new version that > > removes the support for optional arguments? > > > > Lastly, when will the new version of the UFS that removes optional > > variables be available? > > > > Thank you! > > > > On Mon, Oct 4, 2021 at 3:02 PM Dom Heinzeller ***@***.***> > > wrote: > > > > > Dom, Merra2 aerosol aware does not need nwfa2d and nifa2d. As optional > > > variables, they do not need to be passed in mp_gt_driver when > mraerosol is > > > true. We need to turn the reading and writing of nifa2d and nwfa2d > off too. > > > … <#m_2463767692776519034_> > > > > > > Anning, I believe the easiest solution would be to simply allocate > nifa2d > > > and nwfa2d as a dummy array with only one element, and set it to NaN. > Then > > > modify the logic in the I/O layer of fv3atm to not write out those > arrays > > > when mraerosol is true. In ccpp-physics, we do the same. Just write > the > > > logic such that nifa2d and nwfa2d are never read or written when > mraerosol > > > is true. No need to change any of the optional argument logic for > now. We > > > (CCPP developers) can take care of that when we remove the support for > > > optional arguments from CCPP altogether (which is on our todo list > anyway). > > > > > > The only other thing I would add in mp_thompson_init is a consistency > > > check that either mraerosol or ltaerosol or none of them is true, but > not > > > both of them at the same time. > > > > > > — > > > You are receiving this because you were mentioned. > > > Reply to this email directly, view it on GitHub > > > < > #746 (reply in thread) > >, > > > or unsubscribe > > > < > https://github.com/notifications/unsubscribe-auth/ALQPMIKYYQII33UILEU5WILUFH22RANCNFSM5E3UAFSQ > > > > > . > > > Triage notifications on the go with GitHub Mobile for iOS > > > < > https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 > > > > > or Android > > > < > https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub > >. > > > > > > > > — > > You are receiving this because you authored the thread. > > Reply to this email directly, view it on GitHub < > #746 (comment)>, > or unsubscribe < > https://github.com/notifications/unsubscribe-auth/AB5C2RKSIPXOCZ3FAFL4SPTUFH7ZNANCNFSM5E3UAFSQ > >. > > Triage notifications on the go with GitHub Mobile for iOS < > https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android < > https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > > > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#746 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ALQPMIORRZLCJYFWZRY2R2TUFIA33ANCNFSM5E3UAFSQ> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > >

[AnningCheng-NOAA]

Hi, Dom, The branch name is mraerosol. On Mon, Oct 4, 2021 at 4:00 PM Anning Cheng - NOAA Affiliate < ***@***.***> wrote:

…

here is my fv3atm branch: https://github.com/AnningCheng-NOAA/fv3atm. I copied the physical directory last time On Mon, Oct 4, 2021 at 3:59 PM Anning Cheng - NOAA Affiliate < ***@***.***> wrote: > Hi, Dom: > > That is great. > > My ccpp/physics branch: https://github.com/AnningCheng-NOAA/ccpp-physics > my fv3atm > branch: /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/FV3 > > Please let me know when you are done, > Thank you! > > Anning > > On Mon, Oct 4, 2021 at 3:53 PM Dom Heinzeller ***@***.***> > wrote: > >> Anning, if you point me to your branches of fv3atm and ccpp-physics on >> github, then I can check out the code, make the necessary adjustments and >> send you a pull request to merge. This way you can see what I changed, and >> I can go over the changes with you line by line. >> >> > On Oct 4, 2021, at 1:44 PM, AnningCheng-NOAA ***@***.***> wrote: >> > >> > >> > Dom, >> > great to know. >> > Where is the code that read and write nifa2d and nwfa2d? I have >> difficulty >> > locating the piece of code. >> > >> > The current version nifa and nwfa are optional variables. When they >> are not >> > read in the field-table, the cap to call mp_thompson does not include >> nifa >> > and nwfa. Is there any way to change the framework to include nifa and >> > nwfa in the current version or we have to wait for the new version that >> > removes the support for optional arguments? >> > >> > Lastly, when will the new version of the UFS that removes optional >> > variables be available? >> > >> > Thank you! >> > >> > On Mon, Oct 4, 2021 at 3:02 PM Dom Heinzeller ***@***.***> >> > wrote: >> > >> > > Dom, Merra2 aerosol aware does not need nwfa2d and nifa2d. As >> optional >> > > variables, they do not need to be passed in mp_gt_driver when >> mraerosol is >> > > true. We need to turn the reading and writing of nifa2d and nwfa2d >> off too. >> > > … <#m_2463767692776519034_> >> > > >> > > Anning, I believe the easiest solution would be to simply allocate >> nifa2d >> > > and nwfa2d as a dummy array with only one element, and set it to >> NaN. Then >> > > modify the logic in the I/O layer of fv3atm to not write out those >> arrays >> > > when mraerosol is true. In ccpp-physics, we do the same. Just write >> the >> > > logic such that nifa2d and nwfa2d are never read or written when >> mraerosol >> > > is true. No need to change any of the optional argument logic for >> now. We >> > > (CCPP developers) can take care of that when we remove the support >> for >> > > optional arguments from CCPP altogether (which is on our todo list >> anyway). >> > > >> > > The only other thing I would add in mp_thompson_init is a consistency >> > > check that either mraerosol or ltaerosol or none of them is true, >> but not >> > > both of them at the same time. >> > > >> > > — >> > > You are receiving this because you were mentioned. >> > > Reply to this email directly, view it on GitHub >> > > < >> #746 (reply in thread) >> >, >> > > or unsubscribe >> > > < >> https://github.com/notifications/unsubscribe-auth/ALQPMIKYYQII33UILEU5WILUFH22RANCNFSM5E3UAFSQ >> > >> > > . >> > > Triage notifications on the go with GitHub Mobile for iOS >> > > < >> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 >> > >> > > or Android >> > > < >> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub >> >. >> > > >> > > >> > — >> > You are receiving this because you authored the thread. >> > Reply to this email directly, view it on GitHub < >> #746 (comment)>, >> or unsubscribe < >> https://github.com/notifications/unsubscribe-auth/AB5C2RKSIPXOCZ3FAFL4SPTUFH7ZNANCNFSM5E3UAFSQ >> >. >> > Triage notifications on the go with GitHub Mobile for iOS < >> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> >> or Android < >> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. >> >> > >> >> — >> You are receiving this because you were mentioned. >> Reply to this email directly, view it on GitHub >> <#746 (comment)>, >> or unsubscribe >> <https://github.com/notifications/unsubscribe-auth/ALQPMIORRZLCJYFWZRY2R2TUFIA33ANCNFSM5E3UAFSQ> >> . >> Triage notifications on the go with GitHub Mobile for iOS >> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> >> or Android >> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. >> >> >

[AnningCheng-NOAA]

H, Dom: I have a new commitment on mraerosol branch. Some compilation errors, such as "mass_number_concentration_of_cloud_liquid_water_particles_in_air" not found in mp_thompson_init, have been fixed. The branch can pass compilation now, but it cannot run. On Mon, Oct 4, 2021 at 4:07 PM Anning Cheng - NOAA Affiliate < ***@***.***> wrote:

…

Hi, Dom, The branch name is mraerosol. On Mon, Oct 4, 2021 at 4:00 PM Anning Cheng - NOAA Affiliate < ***@***.***> wrote: > here is my fv3atm branch: https://github.com/AnningCheng-NOAA/fv3atm. I > copied the physical directory last time > > On Mon, Oct 4, 2021 at 3:59 PM Anning Cheng - NOAA Affiliate < > ***@***.***> wrote: > >> Hi, Dom: >> >> That is great. >> >> My ccpp/physics branch: https://github.com/AnningCheng-NOAA/ccpp-physics >> my fv3atm >> branch: /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/FV3 >> >> Please let me know when you are done, >> Thank you! >> >> Anning >> >> On Mon, Oct 4, 2021 at 3:53 PM Dom Heinzeller ***@***.***> >> wrote: >> >>> Anning, if you point me to your branches of fv3atm and ccpp-physics on >>> github, then I can check out the code, make the necessary adjustments and >>> send you a pull request to merge. This way you can see what I changed, and >>> I can go over the changes with you line by line. >>> >>> > On Oct 4, 2021, at 1:44 PM, AnningCheng-NOAA ***@***.***> wrote: >>> > >>> > >>> > Dom, >>> > great to know. >>> > Where is the code that read and write nifa2d and nwfa2d? I have >>> difficulty >>> > locating the piece of code. >>> > >>> > The current version nifa and nwfa are optional variables. When they >>> are not >>> > read in the field-table, the cap to call mp_thompson does not include >>> nifa >>> > and nwfa. Is there any way to change the framework to include nifa and >>> > nwfa in the current version or we have to wait for the new version >>> that >>> > removes the support for optional arguments? >>> > >>> > Lastly, when will the new version of the UFS that removes optional >>> > variables be available? >>> > >>> > Thank you! >>> > >>> > On Mon, Oct 4, 2021 at 3:02 PM Dom Heinzeller ***@***.***> >>> > wrote: >>> > >>> > > Dom, Merra2 aerosol aware does not need nwfa2d and nifa2d. As >>> optional >>> > > variables, they do not need to be passed in mp_gt_driver when >>> mraerosol is >>> > > true. We need to turn the reading and writing of nifa2d and nwfa2d >>> off too. >>> > > … <#m_2463767692776519034_> >>> > > >>> > > Anning, I believe the easiest solution would be to simply allocate >>> nifa2d >>> > > and nwfa2d as a dummy array with only one element, and set it to >>> NaN. Then >>> > > modify the logic in the I/O layer of fv3atm to not write out those >>> arrays >>> > > when mraerosol is true. In ccpp-physics, we do the same. Just write >>> the >>> > > logic such that nifa2d and nwfa2d are never read or written when >>> mraerosol >>> > > is true. No need to change any of the optional argument logic for >>> now. We >>> > > (CCPP developers) can take care of that when we remove the support >>> for >>> > > optional arguments from CCPP altogether (which is on our todo list >>> anyway). >>> > > >>> > > The only other thing I would add in mp_thompson_init is a >>> consistency >>> > > check that either mraerosol or ltaerosol or none of them is true, >>> but not >>> > > both of them at the same time. >>> > > >>> > > — >>> > > You are receiving this because you were mentioned. >>> > > Reply to this email directly, view it on GitHub >>> > > < >>> #746 (reply in thread) >>> >, >>> > > or unsubscribe >>> > > < >>> https://github.com/notifications/unsubscribe-auth/ALQPMIKYYQII33UILEU5WILUFH22RANCNFSM5E3UAFSQ >>> > >>> > > . >>> > > Triage notifications on the go with GitHub Mobile for iOS >>> > > < >>> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 >>> > >>> > > or Android >>> > > < >>> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub >>> >. >>> > > >>> > > >>> > — >>> > You are receiving this because you authored the thread. >>> > Reply to this email directly, view it on GitHub < >>> #746 (comment)>, >>> or unsubscribe < >>> https://github.com/notifications/unsubscribe-auth/AB5C2RKSIPXOCZ3FAFL4SPTUFH7ZNANCNFSM5E3UAFSQ >>> >. >>> > Triage notifications on the go with GitHub Mobile for iOS < >>> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> >>> or Android < >>> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. >>> >>> > >>> >>> — >>> You are receiving this because you were mentioned. >>> Reply to this email directly, view it on GitHub >>> <#746 (comment)>, >>> or unsubscribe >>> <https://github.com/notifications/unsubscribe-auth/ALQPMIORRZLCJYFWZRY2R2TUFIA33ANCNFSM5E3UAFSQ> >>> . >>> Triage notifications on the go with GitHub Mobile for iOS >>> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> >>> or Android >>> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. >>> >>> >>

[climbfuji]

I started working on this two days ago, but didn't get to a point where I can share the code with you. Will pull your updates in and continue ...

…

On Oct 6, 2021, at 8:57 AM, AnningCheng-NOAA ***@***.***> wrote: H, Dom: I have a new commitment on mraerosol branch. Some compilation errors, such as "mass_number_concentration_of_cloud_liquid_water_particles_in_air" not found in mp_thompson_init, have been fixed. The branch can pass compilation now, but it cannot run. On Mon, Oct 4, 2021 at 4:07 PM Anning Cheng - NOAA Affiliate < ***@***.***> wrote: > Hi, Dom, The branch name is mraerosol. > > On Mon, Oct 4, 2021 at 4:00 PM Anning Cheng - NOAA Affiliate < > ***@***.***> wrote: > >> here is my fv3atm branch: https://github.com/AnningCheng-NOAA/fv3atm. I >> copied the physical directory last time >> >> On Mon, Oct 4, 2021 at 3:59 PM Anning Cheng - NOAA Affiliate < >> ***@***.***> wrote: >> >>> Hi, Dom: >>> >>> That is great. >>> >>> My ccpp/physics branch: https://github.com/AnningCheng-NOAA/ccpp-physics >>> my fv3atm >>> branch: /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/FV3 >>> >>> Please let me know when you are done, >>> Thank you! >>> >>> Anning >>> >>> On Mon, Oct 4, 2021 at 3:53 PM Dom Heinzeller ***@***.***> >>> wrote: >>> >>>> Anning, if you point me to your branches of fv3atm and ccpp-physics on >>>> github, then I can check out the code, make the necessary adjustments and >>>> send you a pull request to merge. This way you can see what I changed, and >>>> I can go over the changes with you line by line. >>>> >>>> > On Oct 4, 2021, at 1:44 PM, AnningCheng-NOAA ***@***.***> wrote: >>>> > >>>> > >>>> > Dom, >>>> > great to know. >>>> > Where is the code that read and write nifa2d and nwfa2d? I have >>>> difficulty >>>> > locating the piece of code. >>>> > >>>> > The current version nifa and nwfa are optional variables. When they >>>> are not >>>> > read in the field-table, the cap to call mp_thompson does not include >>>> nifa >>>> > and nwfa. Is there any way to change the framework to include nifa and >>>> > nwfa in the current version or we have to wait for the new version >>>> that >>>> > removes the support for optional arguments? >>>> > >>>> > Lastly, when will the new version of the UFS that removes optional >>>> > variables be available? >>>> > >>>> > Thank you! >>>> > >>>> > On Mon, Oct 4, 2021 at 3:02 PM Dom Heinzeller ***@***.***> >>>> > wrote: >>>> > >>>> > > Dom, Merra2 aerosol aware does not need nwfa2d and nifa2d. As >>>> optional >>>> > > variables, they do not need to be passed in mp_gt_driver when >>>> mraerosol is >>>> > > true. We need to turn the reading and writing of nifa2d and nwfa2d >>>> off too. >>>> > > … <#m_2463767692776519034_> >>>> > > >>>> > > Anning, I believe the easiest solution would be to simply allocate >>>> nifa2d >>>> > > and nwfa2d as a dummy array with only one element, and set it to >>>> NaN. Then >>>> > > modify the logic in the I/O layer of fv3atm to not write out those >>>> arrays >>>> > > when mraerosol is true. In ccpp-physics, we do the same. Just write >>>> the >>>> > > logic such that nifa2d and nwfa2d are never read or written when >>>> mraerosol >>>> > > is true. No need to change any of the optional argument logic for >>>> now. We >>>> > > (CCPP developers) can take care of that when we remove the support >>>> for >>>> > > optional arguments from CCPP altogether (which is on our todo list >>>> anyway). >>>> > > >>>> > > The only other thing I would add in mp_thompson_init is a >>>> consistency >>>> > > check that either mraerosol or ltaerosol or none of them is true, >>>> but not >>>> > > both of them at the same time. >>>> > > >>>> > > — >>>> > > You are receiving this because you were mentioned. >>>> > > Reply to this email directly, view it on GitHub >>>> > > < >>>> #746 (reply in thread) >>>> >, >>>> > > or unsubscribe >>>> > > < >>>> https://github.com/notifications/unsubscribe-auth/ALQPMIKYYQII33UILEU5WILUFH22RANCNFSM5E3UAFSQ >>>> > >>>> > > . >>>> > > Triage notifications on the go with GitHub Mobile for iOS >>>> > > < >>>> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 >>>> > >>>> > > or Android >>>> > > < >>>> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub >>>> >. >>>> > > >>>> > > >>>> > — >>>> > You are receiving this because you authored the thread. >>>> > Reply to this email directly, view it on GitHub < >>>> #746 (comment)>, >>>> or unsubscribe < >>>> https://github.com/notifications/unsubscribe-auth/AB5C2RKSIPXOCZ3FAFL4SPTUFH7ZNANCNFSM5E3UAFSQ >>>> >. >>>> > Triage notifications on the go with GitHub Mobile for iOS < >>>> https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> >>>> or Android < >>>> https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. >>>> >>>> > >>>> >>>> — >>>> You are receiving this because you were mentioned. >>>> Reply to this email directly, view it on GitHub >>>> <#746 (comment)>, >>>> or unsubscribe >>>> <https://github.com/notifications/unsubscribe-auth/ALQPMIORRZLCJYFWZRY2R2TUFIA33ANCNFSM5E3UAFSQ> >>>> . >>>> Triage notifications on the go with GitHub Mobile for iOS >>>> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> >>>> or Android >>>> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. >>>> >>>> >>> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#746 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RO3QSS5LDQJ5XBWG4LUFRPUTANCNFSM5E3UAFSQ>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.