master: fix travis build #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
=======================================
Coverage 47.28% 47.28%
=======================================
Files 14 14
Lines 1343 1343
=======================================
Hits 635 635
Misses 708 708Continue to review full report at Codecov.
|
climbfuji
requested review from
gold2718,
grantfirl and
llpcarson
as code owners
gold2718
approved these changes
Jan 12, 2020
Thanks. The unit tests were designed for the dynamic build a while ago and are exercising explicit calls to ccpp_field_add to populate the cdata structure with pointers to the variables etc. Looking forward to Julie's and your work to create a robust testing framework for the new cap_gen.py! |
This was referenced Jan 24, 2020
climbfuji
added a commit
to climbfuji/ccpp-framework
that referenced
this pull request
Jan 27, 2020
…d_20200111 master: fix travis build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix travis build/testing by setting STATIC option correctly for standalone build and adding the missing new configuration option DEFAULT_BUILD_DIR to the standalone build CCPP prebuild config.