Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect minimum supported CMake version #1919

Closed
ckhroulev opened this issue Mar 25, 2022 · 2 comments
Closed

Incorrect minimum supported CMake version #1919

ckhroulev opened this issue Mar 25, 2022 · 2 comments

Comments

@ckhroulev
Copy link
Contributor

cmake_minimum_required (VERSION 2.8.12) in CMakeLists.txt appears to be wrong: src/clib/CMakeLists.txt uses string(APPEND ...), which was added in CMake 3.4 (see https://cmake.org/cmake/help/v3.4/command/string.html).
@jedwards4b
Copy link
Contributor

Thanks for pointing this out. I have changed the minimum version to 3.9.1 based on the oldest version I have easy access to and can test.

@jedwards4b jedwards4b mentioned this issue Mar 29, 2022
Merged
@ckhroulev
Copy link
Contributor Author

@jedwards4b Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ckhroulev @jedwards4b