Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake doesn't detect DAP in recent NetCDF versions #1863

Closed
rjdave opened this issue Mar 5, 2021 · 0 comments · Fixed by #1864
Closed

cmake doesn't detect DAP in recent NetCDF versions #1863

rjdave opened this issue Mar 5, 2021 · 0 comments · Fixed by #1864

Comments

@rjdave
Copy link

rjdave commented Mar 5, 2021

I don't know when the change occurred in ${NetCDF_C_INCLUDE_DIR}/includes/netcdf_meta.h but at least as far back as NetCDF-C v4.5.0, 'NC_HAS_DAP' was replaced by 'NC_HAS_DAP2' and 'NC_HAS_DAP4'. The code in cmake/TryNetCDF_DAP.c causes linking with any semi-recent, DAP enabled version of NetCDF to fail because the search for curl and subsequent addition to the NetCDF_C_Libraries list is omitted. I believe line 8 of cmake/TryNetCDF_DAP.c should read:

#if NC_HAS_DAP==1 || NC_HAS_DAP2==1 || NC_HAS_DAP4==1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix error in check_netcdf call and in detecting dap jedwards4b/ParallelIO
1 participant
@rjdave