Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatars aren't working #13

Closed
Ismoh opened this issue Aug 31, 2022 · 5 comments · Fixed by #14
Closed

Avatars aren't working #13

Ismoh opened this issue Aug 31, 2022 · 5 comments · Fixed by #14
Assignees
Labels
Feature Request Request to add a new feature

Comments

@Ismoh
Copy link

Ismoh commented Aug 31, 2022

Here you can see my workflow action yaml:

name: Gource
on:
  push:
    branches:
      - '**'

jobs:
  action:
    runs-on: ubuntu-latest
    
    steps:
      - name: 'Checkout'
        uses: actions/checkout@v2
        with:
          fetch-depth: 0

      - name: 'Gource Action'
        uses: nbprojekt/gource-action@v1
        with:
          avatars_auto_fetch: true
          gource_title: 'NoitaMP Gource master'
          gource_resolution: '1080p'
          gource_fps: 60
          gource_font_size: 40
          gource_auto_skip_seconds: 0.1
          gource_seconds_per_day: 0.1

      - name: 'Upload gource video'
        uses: actions/upload-artifact@v2
        with:
          name: Gource
          path: ./gource/gource.mp4

https://github.com/Ismoh/NoitaMP/blob/69-integrate-gourceio-because-its-fun/.github/workflows/gource.yml#L20

As you can see in the action result, there aren't any avatars shown:
https://github.com/Ismoh/NoitaMP/actions/runs/2962234230
image

Only the artifact:
https://github.com/Ismoh/NoitaMP/suites/8064812629/artifacts/347452077

@NBprojekt NBprojekt self-assigned this Aug 31, 2022
@NBprojekt NBprojekt added the Bug Something isn't working label Aug 31, 2022
@NBprojekt
Copy link
Owner

NBprojekt commented Sep 6, 2022

Thank you for the ticket.

After investigating the actions is working as expected.

Please note the the action only can fetch your avatar when your commit email is your primary email in GitHub.
That for example the reason why this feature does not work for my old repos, because I changed my primary email.

For debugging I printed all your contributor names, commit email and the matching api call for your repository.

In your repository not a single email can be resolve to an actual image.

In your case I would save all user avatars inside a folder and link it using the avatars_url parameter.

If you need further help, don't hesitate to ask.

@NBprojekt NBprojekt closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2022
@NBprojekt NBprojekt removed the Bug Something isn't working label Sep 6, 2022
@Ismoh
Copy link
Author

Ismoh commented Sep 6, 2022

Ah it's because my email is set to private and replaced with [email protected].
Please do me a favour and remove the mails in your comment above.
Thanks for investigating time and providing a additional solution!

@NBprojekt
Copy link
Owner

I just found an end point in the GitHub api when you can fetch the user avatar by name.
This requires the commit name to be the same as the GitHub name but its with a try.

In the upcoming days I will push a new version which check for commit email and name.

@NBprojekt NBprojekt reopened this Sep 6, 2022
@NBprojekt
Copy link
Owner

NBprojekt commented Sep 6, 2022

This works for most of your commits: artifacts

@Ismoh
Copy link
Author

Ismoh commented Sep 12, 2022

Thanks a ton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Request to add a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants