Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate complains of missing CRLF line endings despite their presence #820

Closed
nutjob4life opened this issue Feb 1, 2024 · 1 comment
Closed
Assignees
Labels
bug Something isn't working invalid This doesn't seem right needs:triage

Comments

@nutjob4life
Copy link
Member

Checked for duplicates

Yes - I've already checked

🐛 Describe the bug

When I ran validate on this set of files using this command:

/tmp/validate-3.5.0-SNAPSHOT/bin/validate --target *.xml

I got told that the magellan_gxdr_v1.0_20240201_transfer_manifest_v1.0.tab file didn't have CRLF line endings. However, the Unix file command says it does:

$ file magellan_gxdr_v1.0_20240201_transfer_manifest_v1.0.tab
magellan_gxdr_v1.0_20240201_transfer_manifest_v1.0.tab: ASCII text, with very long lines (511), with CRLF line terminators

Also, opening the file in Hex Fiend shows 0D0A with 0D = CR and 0A = LF.
hex fiend

🕵️ Expected behavior

I expected better, frankly 😆

Just kidding. I guess I expected there to be no CRLF issues.

📜 To Reproduce

  1. Build and install a recent Validate
  2. Download the files in the ZIP archive (above)
  3. Run validate --target *.xml

🖥 Environment Info

  • Validate-3.5.0-SNAPSHOT
  • macOS 14.2.1

📚 Version of Software Used

No response

🩺 Test Data / Additional context

No response

🦄 Related requirements

🦄 #xyz

⚙️ Engineering Details

No response

@jordanpadams
Copy link
Member

For the example data cited, the record_length was incorrect, so validate was reading up to CR, and then everything gets out of whack. Closing as invalid.

@github-project-automation github-project-automation bot moved this from Backlog to 🏁 Done in EN Portfolio Backlog Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right needs:triage
Projects
Status: 🏁 Done
Development

No branches or pull requests

2 participants