Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I want to apply an additional query filter (q=) to the /classes/{class} result set #493

Closed
jordanpadams opened this issue Jul 12, 2024 · 7 comments

Comments

@jordanpadams
Copy link
Member

jordanpadams commented Jul 12, 2024

Checked for duplicates

Yes - I've already checked

πŸ§‘β€πŸ”¬ User Persona(s)

Data User

πŸ’ͺ Motivation

...so that I can search for the products of a particular class, and then provide additional filters to the search within the result set.

πŸ“– Additional Details

No response

Acceptance Criteria

Given two Product_Collection products collection_x::1.0 with target Mars, collection_y::1.0 with target Moon loaded into the registry
When I perform GET /classes/collections?q=(ref_lid_target eq 'urn:nasa:pds:context:target:planet.mars'
Then I expect product collection_x::1.0 to be in the result set

βš™οΈ Engineering Details

No response

πŸŽ‰ I&T

No response

@alexdunnjpl
Copy link
Contributor

@jordanpadams this is already implemented in #512

https://github.com/NASA-PDS/registry-api/pull/512/files#diff-86005b9ee122b899829313c52db78ee498ab2100bdd096d31ebcb06c1bc10d6dR623

As far as tests go, I'd suggest a test for each dot-method and implementing #515 to eliminate the need to test each endpoint's use of already-implemented behaviour

@alexdunnjpl
Copy link
Contributor

@jordanpadams am I good to close this issue?

@github-project-automation github-project-automation bot moved this from ToDo to 🏁 Done in EN Portfolio Backlog Aug 6, 2024
@tloubrieu-jpl tloubrieu-jpl reopened this Aug 6, 2024
@github-project-automation github-project-automation bot moved this from 🏁 Done to In Progress in EN Portfolio Backlog Aug 6, 2024
@alexdunnjpl
Copy link
Contributor

Context: reopened, I assume, due to outstanding discussion to be had over required granularity of test-cases

@alexdunnjpl
Copy link
Contributor

@jordanpadams @tloubrieu-jpl is the plan to cover this at today's breakout?

@tloubrieu-jpl
Copy link
Member

Yes @alexdunnjpl , we can discuss it

@alexdunnjpl alexdunnjpl removed their assignment Aug 13, 2024
@alexdunnjpl
Copy link
Contributor

reassigned to Thomas for disposition

@tloubrieu-jpl
Copy link
Member

validated with new test in PR NASA-PDS/registry#313

@github-project-automation github-project-automation bot moved this from In Progress to 🏁 Done in EN Portfolio Backlog Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏁 Done
Development

No branches or pull requests

3 participants