Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

q parameter does not work on members end-point #197

Closed
tloubrieu-jpl opened this issue Nov 30, 2022 · 5 comments
Closed

q parameter does not work on members end-point #197

tloubrieu-jpl opened this issue Nov 30, 2022 · 5 comments
Assignees
Labels
B13.1 bug Something isn't working s.medium Medium level severity wontfix This will not be worked on

Comments

@tloubrieu-jpl
Copy link
Member

🐛 Describe the bug

I am not sure if that is intended to work in the first place, but in case yes,

the following request

curl --get 'http://pds.nasa.gov/api/search-en-gamma/1.1/classes/collections/urn:nasa:pds:gbo.pluto-charon.mutual-events:data::1.0/members' --data-urlencode 'q=pds:External_Reference.pds:reference_text eq "YOUNG1992"' -H Accept:application/json -L | json_pp

Does not filter the results. We get the same response with request:

curl --get 'http://pds.nasa.gov/api/search-en-gamma/1.1/classes/collections/urn:nasa:pds:gbo.pluto-charon.mutual-events:data::1.0/members' -H Accept:application/json -L | json_pp

🕵️ Expected behavior

The filter should (To Be confirmed) apply to the members of the collection requested.

📚 Version of Software Used

1.1

@tloubrieu-jpl tloubrieu-jpl added bug Something isn't working needs:triage labels Nov 30, 2022
@tloubrieu-jpl tloubrieu-jpl added B13.1 s.medium Medium level severity and removed needs:triage labels Nov 30, 2022
@jordanpadams jordanpadams changed the title q on members end-point q parameter does not work on members end-point Feb 2, 2023
@tloubrieu-jpl
Copy link
Member Author

For this ticket, focus on /products/{id}/members... since the /classes/{class}/{id}/memebers... are now deprecated.

@alexdunnjpl
Copy link
Contributor

@jordanpadams can you confirm that this behaviour is a requirement? (Only asking since Thomas mentioned that it's unclear)

@jordanpadams
Copy link
Member

@alexdunnjpl I think we want to support q= across all endpoints (why wouldn't we?), but if there are other higher priority bugs out there, this isn't totally critical.

@alexdunnjpl
Copy link
Contributor

@jordanpadams after digging through the relevant code and running it by @al-niessner, the short answer to "why wouldn't we" is "because the raw query q= is intended as a way to expose a low-level interface for custom querying, and the architecture isn't designed to support combination in the necessary fashion".

An alternative approach to provide similar functionality is to extend the query language to include operators for references (ex. /products?q="grandchild-of urn:bundle::1.0 and instrument = mars_hires_camera)

@jordanpadams
Copy link
Member

@al-niessner @alexdunnjpl copy. we can close this as wontfix, but I will create a new requirement to support more complex queries combining both aggregation searches with metadata searches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B13.1 bug Something isn't working s.medium Medium level severity wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants