Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Harvest does not work with registry manager #2

Closed
tloubrieu-jpl opened this issue Mar 29, 2020 · 5 comments
Closed

Harvest does not work with registry manager #2

tloubrieu-jpl opened this issue Mar 29, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@tloubrieu-jpl
Copy link
Contributor

Describe the bug
When i follow the test procedure for the registry app, the record produced by harvest cannot be saved in registry with the registry manager command

To Reproduce
Steps to reproduce the behavior:

  1. clone pds-app-registry
  2. generate the site with mvn site
  3. follow instructions in install/test
  4. See error:
    $ registry-manager load-data -filePath ~/tmp/harvest_result00/
    Loading file: /Users/loubrieu/tmp/harvest_result00/solr-docs.xml
    ERROR: Error from server at http://localhost:8983/solr: ERROR: [doc=::] Error adding field 'vid'='' msg=empty String

Expected behavior
No error, the record should be inserted in the registry.

** Version of Software Used**
harvest 3.2.0
registry 3.2.0
pds-app-registry 0.1.0
jdk 11

Desktop (please complete the following information):

  • OS: macos
@tloubrieu-jpl
Copy link
Contributor Author

Sorry, I had created that on Thursday but that has not been saved from some reason.
The thing is that i have not been able to ingest in registry record that where created from test dataset taken in https://pds.nasa.gov/datastandards/documents/examples/v1/DPH_Examples_V11300.zip

These data are packaged with the pds-app-registry release, in the "test" subdirectory.

@tdddblog
Copy link
Contributor

tdddblog commented Mar 30, 2020

Added validation for empty lid and vid fields and optional -stopOnError flag. See Issue #22 in Harvest. By default invalid PDS4 labels are skipped with an error message. To stop on error use new -stopOnError flag.

@tloubrieu-jpl
Copy link
Contributor Author

The reason for the error I initially had with the example dataset is that there are 2 versions of the same dataset (archive and products) in the package. I should not harvest both directories, only archive. I am updating the test guide and creating the package with that.

@tloubrieu-jpl
Copy link
Contributor Author

The test doc is updated so that the harvest works on the test datasets.
The harvest software is updated so that it does stops with critical error when lid/vid can not be created (e.g. when the same ids are used in the same harvest batch).

@jordanpadams
Copy link
Contributor

closed per #105

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants