Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Test data in pds-registry-app-0.2.2-bin.zip contains invalid PDS4 labels #109

Closed
tdddblog opened this issue Dec 16, 2020 · 5 comments
Closed
Assignees
Labels
bug Something isn't working s.high

Comments

@tdddblog
Copy link
Contributor

tdddblog commented Dec 16, 2020

Describe the bug
Test data in pds-registry-app-0.2.2-bin.zip contains invalid PDS4 labels.

To Reproduce

  1. Build pds-registry-app project yourself or download 0.2.2 release ZIP.
  2. Extract the ZIP.
  3. Check /test/dph_example_products/Product_Observational/Table_Character_draft1.xml file.
  4. The file has empty lid and vid fields:
<logical_identifier/>
<version_id/>

As expected Harvest could not process this file and exit with an error message:
[ERROR] Missing logical identifier: /C:/tmp/d4/dph_example_products/Product_Observational/Table_Character_draft1.xml

Expected behavior
It is not clear if invalid file was included intentionally to check Harvest error handling. If that's the case, I would move invalid file(s) to a separate folder. Some users complained that they could not use test data with Harvest.

Version of Software Used
pds-registry-app-0.2.2

Desktop (please complete the following information):
Windows 10

@tdddblog tdddblog added bug Something isn't working triage-needed labels Dec 16, 2020
@tloubrieu-jpl
Copy link
Contributor

@tdddblog this issues is related to ticket NASA-PDS/harvest#22 which is closed.

I don't think I had an issue with that with harvest but may be with registry-mgr. I need to check again.

@tloubrieu-jpl
Copy link
Contributor

I removed the file from the package so this ticket can be closed.

A follow on ticket can be to remove or update the label in the original example that I am using here https://pds.nasa.gov/datastandards/documents/examples/

@rchenatjpl
Copy link

@tloubrieu-jpl I don't see any test labels in pds-registry-app-0.3.1.

@tloubrieu-jpl
Copy link
Contributor

@rchenatjpl yes you are right, it looks like something went wrong in the packaging step. Let me look at that.

@tloubrieu-jpl
Copy link
Contributor

@rchenatjpl , @jordanpadams, for a reason I don't understand yet the stable release continuous integration generate a different package than a local mvn package launched manually.

For now I replace the release files for version 0.3.2 with the manually generated packages, which contain the test dataset.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working s.high
Projects
None yet
Development

No branches or pull requests

3 participants