refactor: Remove USWDS assets from the lib bundle #1467
+20
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dzole0311
changed the title
| @@ -101,13 +101,16 @@ | |||
| }); | |||
| </script> | |||
|
|
|||
| <!-- Theme CSS - only populated by legacy VEDA-config instances, not used in standalone VEDA UI mode --> | |||
| <link rel="stylesheet" href="../static/styles/theme.css"> | |||
There was a problem hiding this comment.
oh it looks like parcel adds cache busting hash anyway even if the css was included in this way. noice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: #1389
Related veda-config PR: NASA-IMPACT/veda-config#720
Description of Changes
theme.cssfile with a warning about its purpose. The file will be populated only by the veda-config build processNotes & Questions About Changes
This PR is part of a coordinated update with NASA-IMPACT/veda-config#720 to implement USWDS theming for the current generation of VEDA instances
Validation / Testing
Most of the testing is done via the veda-config PR. Here we only need to quickly verify:
yarn servein theveda-uirepo and confirm the app loads with the styling set in theuswds-theme.scss