Assess USWDS theming for legacy veda-config instances #1389
Assignees
Comments
dzole0311
added a commit
that referenced
this issue
Feb 10, 2025
**Related Ticket:** #1415 ### Description of Changes Make the USWDS banner flag path and alt texts configurable. The USWDS assets are currently resolved incorrectly because they're using absolute paths (starting with '/') which are being resolved relative to earth.gov instead of earth.gov/ghgcenter. As an immediate fix, this PR makes the flag path configurable so we can adjust it based on the deployment context. ### Notes & Questions About Changes - Path resolution could potentially affect other USWDS assets beyond the flag and in other components. We'll be tackling this via #1429 (subpath route handling) and #1389 ### Validation / Testing - Start veda-ui locally - Change the `flagImgSrc` path in veda-config.js to `/img/icon-https.svg` - Restart your server - Verify that the flag img in the banner shows the new icon - Change it back the original flag path - Verify that the flag icon is shown
dzole0311
added a commit
that referenced
this issue
Feb 10, 2025
**Related Ticket:** #1415 Make the USWDS banner flag path and alt texts configurable. The USWDS assets are currently resolved incorrectly because they're using absolute paths (starting with '/') which are being resolved relative to earth.gov instead of earth.gov/ghgcenter. As an immediate fix, this PR makes the flag path configurable so we can adjust it based on the deployment context. - Path resolution could potentially affect other USWDS assets beyond the flag and in other components. We'll be tackling this via #1429 (subpath route handling) and #1389 - Start veda-ui locally - Change the `flagImgSrc` path in veda-config.js to `/img/icon-https.svg` - Restart your server - Verify that the flag img in the banner shows the new icon - Change it back the original flag path - Verify that the flag icon is shown
dzole0311
added a commit
that referenced
this issue
Feb 10, 2025
**Related Ticket:** #1415 Make the USWDS banner flag path and alt texts configurable. The USWDS assets are currently resolved incorrectly because they're using absolute paths (starting with '/') which are being resolved relative to earth.gov instead of earth.gov/ghgcenter. As an immediate fix, this PR makes the flag path configurable so we can adjust it based on the deployment context. - Path resolution could potentially affect other USWDS assets beyond the flag and in other components. We'll be tackling this via #1429 (subpath route handling) and #1389 - Start veda-ui locally - Change the `flagImgSrc` path in veda-config.js to `/img/icon-https.svg` - Restart your server - Verify that the flag img in the banner shows the new icon - Change it back the original flag path - Verify that the flag icon is shown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
We have figured out how the USWDS theming will work for the new NextJS-based instances + the veda UI repo for local development.
We also need to assess whether and how USWDS-based theming for veda-ui components can be supported long-term within legacy veda-config instances, when veda-ui is used as a submodule (e.g. the existing
veda-config).Acceptance Criteria
Related Tickets
[If applicable, link any tickets that are related]
The text was updated successfully, but these errors were encountered: