Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tile endpoint for CMIP6 #398

Merged
merged 1 commit into from
May 21, 2024
Merged

Add tile endpoint for CMIP6 #398

merged 1 commit into from
May 21, 2024

Conversation

abarciauskas-bgse
Copy link
Contributor

CMIP6 is broken in the current dashboard because, I think, changes were made to use the tileApiEndpoint for zarr dataset layers.

tileApiEndpoint is marked as an optional parameter but I wonder if it should actually be required.

Copy link

netlify bot commented May 18, 2024

Deploy Preview for visex ready!

Name Link
🔨 Latest commit 5314f9c
🔍 Latest deploy log https://app.netlify.com/sites/visex/deploys/6649381114eca50008c95c1c
😎 Deploy Preview https://deploy-preview-398--visex.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abarciauskas-bgse
Copy link
Contributor Author

@abarciauskas-bgse abarciauskas-bgse changed the title add-tile-endpoint Add tile endpoint for CMIP6 May 18, 2024
@dzole0311
Copy link
Collaborator

Thanks @abarciauskas-bgse, I tested this and it works as expected. I think we could go ahead and merge this so it could be part of the deployment later today.

I also opened a follow-up on the UI side as I think we have two options here. We could either always provide the tileApiEndpoint and the stacApiEndpointas part of the deployments secrets so that we could fallback unto if they are not provided via the MDX (ie. tileApiEndpoint ?? process.env.API_XARRAY_ENDPOINT). The second option is to make them required in the MDX.

@hanbyul-here @sandrahoang686 Any opinions here?

@dzole0311 dzole0311 merged commit 66b2bef into develop May 21, 2024
6 checks passed
@dzole0311 dzole0311 deleted the ab/fix-cmip6-kerchunk branch May 21, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants