Issue #129 - Add error handling for playback module datastore connection #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the server endpoints and Playback class so a failed database connection doesn't prevent the GUI Plugin from functioning / booting normally. The Playback class tracks whether playback is "enabled" and the server endpoints use this status flag to determine how best to respond to requests.
Update the Playback component to display a warning banner if no valid time ranges were returned from the backend. This can either be because there's no valid time ranges of data in the database or (more likely) because the database connection isn't configured or failed.
|
👍 |
MJJoyce
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, failure to connect to the specified datastore crashed the GUI plugin.
Now, on a failed datastore connection the playback functionality will not work but the rest of the GUI will continue to run.