Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AIT-GUI version logging clause under AITGUIPlugin class #180

Open
Futabay opened this issue Nov 7, 2020 · 0 comments
Open

Move AIT-GUI version logging clause under AITGUIPlugin class #180

Futabay opened this issue Nov 7, 2020 · 0 comments

Comments

@Futabay
Copy link
Contributor

Futabay commented Nov 7, 2020

It seems that try / except clause below is related to GUI plugin only. It's a good idea to move the clause under AITGUIPlugin class.

AIT-GUI/ait/gui/__init__.py

Lines 264 to 271 in 66dfe59

try:
with open(os.path.join(HTMLRoot.Static, 'package.json')) as infile:
package_data = json.loads(infile.read())
VERSION = 'AIT GUI v{}'.format(package_data['version'])
log.info('Running {}'.format(VERSION))
except:
VERSION = ''
log.warn('Unable to determine which AIT GUI Version is running')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant