From 7df8070e8e1704f35f9fbc512bf1e22df6c089b2 Mon Sep 17 00:00:00 2001
From: Niels Dekker <N.Dekker@lumc.nl>
Date: Tue, 24 Sep 2024 20:30:57 +0200
Subject: [PATCH] ENH: Add "itkPointSetTest.py" unittest, testing
 `SetPointsByCoordinates`

Specifically tested `SetPointsByCoordinates` with a NumPy array as input
argument, as was suggested by Pranjal Sahu.

- Follow-up to pull request https://github.com/InsightSoftwareConsortium/ITK/pull/4850
commit f43b1b8977fa05d169c14b4c6f44ce35992a3959
ENH: Add `PointSet::SetPointsByCoordinates(coordinates)`
---
 .../Core/Common/wrapping/test/CMakeLists.txt  |  5 ++
 .../Common/wrapping/test/itkPointSetTest.py   | 52 +++++++++++++++++++
 2 files changed, 57 insertions(+)
 create mode 100644 Modules/Core/Common/wrapping/test/itkPointSetTest.py

diff --git a/Modules/Core/Common/wrapping/test/CMakeLists.txt b/Modules/Core/Common/wrapping/test/CMakeLists.txt
index 650a83664b6..8726e63da48 100644
--- a/Modules/Core/Common/wrapping/test/CMakeLists.txt
+++ b/Modules/Core/Common/wrapping/test/CMakeLists.txt
@@ -47,6 +47,11 @@ if(ITK_WRAP_PYTHON)
     itkPointSetSerializationTest
     COMMAND
     ${CMAKE_CURRENT_SOURCE_DIR}/itkPointSetSerializationTest.py)
+  itk_python_add_test(
+    NAME
+    itkPointSetTest
+    COMMAND
+    ${CMAKE_CURRENT_SOURCE_DIR}/itkPointSetTest.py)
   itk_python_add_test(
     NAME
     itkSpatialOrientationAdapterTest
diff --git a/Modules/Core/Common/wrapping/test/itkPointSetTest.py b/Modules/Core/Common/wrapping/test/itkPointSetTest.py
new file mode 100644
index 00000000000..7ce9934f857
--- /dev/null
+++ b/Modules/Core/Common/wrapping/test/itkPointSetTest.py
@@ -0,0 +1,52 @@
+# ==========================================================================
+#
+#   Copyright NumFOCUS
+#
+#   Licensed under the Apache License, Version 2.0 (the "License");
+#   you may not use this file except in compliance with the License.
+#   You may obtain a copy of the License at
+#
+#          https://www.apache.org/licenses/LICENSE-2.0.txt
+#
+#   Unless required by applicable law or agreed to in writing, software
+#   distributed under the License is distributed on an "AS IS" BASIS,
+#   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#   See the License for the specific language governing permissions and
+#   limitations under the License.
+#
+# ==========================================================================*/
+
+import itk
+import unittest
+import numpy as np
+
+class PointSetTestCase(unittest.TestCase):
+    """Tests itk.PointSet"""
+
+    def test_SetPointsByCoordinates_from_NumPy_array(self) -> None:
+        """Tests the SetPointsByCoordinates method, having a NumPy array as input"""
+
+        # The pixel type is irrelevant for this test, just use unsigned char.
+        PixelType = itk.UC
+
+        # Test the most common dimensions, and a few different numbers as number of points.
+        for dimension in [2, 3]:
+            for number_of_points in [1, 4, 9]:
+                # Create a NumPy array of random coordinates between -1.0 and 1.0
+                np_array = 2.0 * np.random.rand(number_of_points * dimension) - 1.0
+
+                point_set = itk.PointSet[PixelType, dimension].New()
+                point_set.SetPointsByCoordinates(np_array)
+
+                points = point_set.GetPoints()
+
+                self.assertEqual(points.Size(), number_of_points)
+
+                for i in range(number_of_points):
+                    point = points.GetElement(i)
+                    for j in range(dimension):
+                        self.assertAlmostEqual(point[j], np_array[i * dimension + j])
+
+
+if __name__ == "__main__":
+    unittest.main()