From 7a5663e7681b1d34783adac780116c173f52eef5 Mon Sep 17 00:00:00 2001 From: Niels Dekker Date: Wed, 4 Dec 2024 12:15:19 +0100 Subject: [PATCH] COMP: Slow down removal of the `CoordRepType` aliases For now, only remove those aliases when explicitly requested by defining `ITK_REMOVE_COORD_REP_TYPES`. The aim is to put them in `#ifndef ITK_FUTURE_LEGACY_REMOVE` with ITK 6.1. --- Modules/Core/Common/include/itkBoundingBox.h | 2 +- Modules/Core/Common/include/itkCellInterface.h | 4 ++-- Modules/Core/Common/include/itkContinuousIndex.h | 2 +- .../Common/include/itkDefaultDynamicMeshTraits.h | 2 +- .../Common/include/itkDefaultStaticMeshTraits.h | 2 +- Modules/Core/Common/include/itkPoint.h | 2 +- Modules/Core/Common/include/itkPointSetBase.h | 2 +- Modules/Core/Common/include/itkTriangleHelper.h | 2 +- .../Core/ImageFunction/include/itkImageFunction.h | 2 +- .../include/itkVectorInterpolateImageFunction.h | 2 +- .../Mesh/include/itkInteriorExteriorMeshFilter.h | 2 +- Modules/Core/Mesh/include/itkMesh.h | 2 +- .../itkParametricSpaceToImageSpaceMeshFilter.h | 2 +- Modules/Core/Mesh/include/itkTransformMeshFilter.h | 2 +- Modules/Core/Mesh/include/itkWarpMeshFilter.h | 2 +- .../include/itkQuadEdgeCellTraitsInfo.h | 2 +- ...geMeshEulerOperatorCreateCenterVertexFunction.h | 2 +- .../include/itkQuadEdgeMeshExtendedTraits.h | 2 +- .../include/itkQuadEdgeMeshFrontIterator.h | 2 +- .../include/itkQuadEdgeMeshToQuadEdgeMeshFilter.h | 4 ++-- .../QuadEdgeMesh/include/itkQuadEdgeMeshTraits.h | 2 +- .../include/itkBSplineTransformInitializer.h | 2 +- .../include/itkBSplineControlPointImageFunction.h | 2 +- .../ImageGrid/include/itkExpandImageFilter.h | 2 +- .../ImageGrid/include/itkWarpImageFilter.h | 2 +- .../ImageGrid/include/itkWarpVectorImageFilter.h | 2 +- .../include/itkVectorExpandImageFilter.h | 2 +- .../include/itkBorderQuadEdgeMeshFilter.h | 4 ++-- .../itkDelaunayConformingQuadEdgeMeshFilter.h | 4 ++-- .../itkParameterizationQuadEdgeMeshFilter.h | 4 ++-- .../itkQuadEdgeMeshParamMatrixCoefficients.h | 14 +++++++------- Modules/IO/MeshBase/include/itkMeshFileReader.h | 2 +- .../include/itkConformalFlatteningMeshFilter.h | 2 +- .../itkMultiphaseFiniteDifferenceImageFilter.h | 2 +- .../include/itkMeanSquareRegistrationFunction.h | 2 +- .../FEM/include/itkFEMRegistrationFilter.h | 2 +- .../FEM/include/itkMIRegistrationFunction.h | 2 +- .../FEM/include/itkNCCRegistrationFunction.h | 2 +- .../include/itkGPUDemonsRegistrationFunction.h | 2 +- .../itkManifoldParzenWindowsPointSetFunction.h | 2 +- .../Metricsv4/include/itkPointSetFunction.h | 2 +- .../itkPointSetToPointSetMetricWithIndexv4.h | 2 +- .../include/itkPointSetToPointSetMetricv4.h | 2 +- .../include/itkDemonsRegistrationFunction.h | 2 +- .../include/itkESMDemonsRegistrationFunction.h | 2 +- ...FastSymmetricForcesDemonsRegistrationFunction.h | 2 +- .../itkLevelSetMotionRegistrationFunction.h | 2 +- .../itkSymmetricForcesDemonsRegistrationFunction.h | 2 +- .../include/itkShapeSignedDistanceFunction.h | 2 +- .../Voronoi/include/itkVoronoiDiagram2D.h | 2 +- .../Voronoi/include/itkVoronoiDiagram2DGenerator.h | 2 +- 51 files changed, 62 insertions(+), 62 deletions(-) diff --git a/Modules/Core/Common/include/itkBoundingBox.h b/Modules/Core/Common/include/itkBoundingBox.h index ffcffc93200..86a3fbbcbfd 100644 --- a/Modules/Core/Common/include/itkBoundingBox.h +++ b/Modules/Core/Common/include/itkBoundingBox.h @@ -90,7 +90,7 @@ class ITK_TEMPLATE_EXPORT BoundingBox : public Object /** Hold on to the type information specified by the template parameters. */ using PointIdentifier = TPointIdentifier; using CoordinateType = TCoordinate; -#ifndef ITK_FUTURE_LEGACY_REMOVE +#ifndef ITK_REMOVE_COORD_REP_TYPES using CoordRepType ITK_FUTURE_DEPRECATED( "ITK 6 discourages using `CoordRepType`. Please use `CoordinateType` instead!") = CoordinateType; #endif diff --git a/Modules/Core/Common/include/itkCellInterface.h b/Modules/Core/Common/include/itkCellInterface.h index cf5e15318a3..08515c15bb7 100644 --- a/Modules/Core/Common/include/itkCellInterface.h +++ b/Modules/Core/Common/include/itkCellInterface.h @@ -110,7 +110,7 @@ class ITK_TEMPLATE_EXPORT CellInterface /** Save type information for this cell. */ using CoordinateType = typename CellTraits::CoordinateType; -#ifndef ITK_FUTURE_LEGACY_REMOVE +#ifndef ITK_REMOVE_COORD_REP_TYPES using CoordRepType ITK_FUTURE_DEPRECATED( "ITK 6 discourages using `CoordRepType`. Please use `CoordinateType` instead!") = CoordinateType; #endif @@ -530,7 +530,7 @@ class ITK_TEMPLATE_EXPORT CellTraitsInfo public: static constexpr unsigned int PointDimension = VPointDimension; using CoordinateType = TCoordinate; -#ifndef ITK_FUTURE_LEGACY_REMOVE +#ifndef ITK_REMOVE_COORD_REP_TYPES using CoordRepType ITK_FUTURE_DEPRECATED( "ITK 6 discourages using `CoordRepType`. Please use `CoordinateType` instead!") = CoordinateType; #endif diff --git a/Modules/Core/Common/include/itkContinuousIndex.h b/Modules/Core/Common/include/itkContinuousIndex.h index 1028a9d8933..7a30496e63f 100644 --- a/Modules/Core/Common/include/itkContinuousIndex.h +++ b/Modules/Core/Common/include/itkContinuousIndex.h @@ -57,7 +57,7 @@ class ITK_TEMPLATE_EXPORT ContinuousIndex : public Point /** Define output mesh types */ using OutputMeshType = TOutputMesh; using OutputCoordinateType = typename OutputMeshType::CoordinateType; -#ifndef ITK_FUTURE_LEGACY_REMOVE +#ifndef ITK_REMOVE_COORD_REP_TYPES using OutputCoordRepType ITK_FUTURE_DEPRECATED( "ITK 6 discourages using `OutputCoordRepType`. Please use `OutputCoordinateType` instead!") = OutputCoordinateType; #endif diff --git a/Modules/Nonunit/Review/include/itkConformalFlatteningMeshFilter.h b/Modules/Nonunit/Review/include/itkConformalFlatteningMeshFilter.h index d5143e7713c..5b0dc3b1cb2 100644 --- a/Modules/Nonunit/Review/include/itkConformalFlatteningMeshFilter.h +++ b/Modules/Nonunit/Review/include/itkConformalFlatteningMeshFilter.h @@ -68,7 +68,7 @@ class ITK_TEMPLATE_EXPORT ConformalFlatteningMeshFilter : public MeshToMeshFilte /** Type for representing coordinates. */ // using CoordinateType = typename TInputMesh::CoordinateType; using CoordinateType = double; -#ifndef ITK_FUTURE_LEGACY_REMOVE +#ifndef ITK_REMOVE_COORD_REP_TYPES using CoordRepType ITK_FUTURE_DEPRECATED( "ITK 6 discourages using `CoordRepType`. Please use `CoordinateType` instead!") = CoordinateType; #endif diff --git a/Modules/Nonunit/Review/include/itkMultiphaseFiniteDifferenceImageFilter.h b/Modules/Nonunit/Review/include/itkMultiphaseFiniteDifferenceImageFilter.h index 43fb46d82b2..698af3f8796 100644 --- a/Modules/Nonunit/Review/include/itkMultiphaseFiniteDifferenceImageFilter.h +++ b/Modules/Nonunit/Review/include/itkMultiphaseFiniteDifferenceImageFilter.h @@ -181,7 +181,7 @@ class ITK_TEMPLATE_EXPORT MultiphaseFiniteDifferenceImageFilter : public InPlace using InputImagePointer = typename InputImageType::Pointer; using InputPointType = typename InputImageType::PointType; using InputCoordinateType = typename InputPointType::CoordinateType; -#ifndef ITK_FUTURE_LEGACY_REMOVE +#ifndef ITK_REMOVE_COORD_REP_TYPES using InputCoordRepType ITK_FUTURE_DEPRECATED( "ITK 6 discourages using `InputCoordRepType`. Please use `InputCoordinateType` instead!") = InputCoordinateType; #endif diff --git a/Modules/Registration/Common/include/itkMeanSquareRegistrationFunction.h b/Modules/Registration/Common/include/itkMeanSquareRegistrationFunction.h index 217fcedf5d8..a449c9f1b15 100644 --- a/Modules/Registration/Common/include/itkMeanSquareRegistrationFunction.h +++ b/Modules/Registration/Common/include/itkMeanSquareRegistrationFunction.h @@ -96,7 +96,7 @@ class ITK_TEMPLATE_EXPORT MeanSquareRegistrationFunction /** Interpolator type. */ using CoordinateType = double; -#ifndef ITK_FUTURE_LEGACY_REMOVE +#ifndef ITK_REMOVE_COORD_REP_TYPES using CoordRepType ITK_FUTURE_DEPRECATED( "ITK 6 discourages using `CoordRepType`. Please use `CoordinateType` instead!") = CoordinateType; #endif diff --git a/Modules/Registration/FEM/include/itkFEMRegistrationFilter.h b/Modules/Registration/FEM/include/itkFEMRegistrationFilter.h index 205d0b28515..2e4378a25e4 100644 --- a/Modules/Registration/FEM/include/itkFEMRegistrationFilter.h +++ b/Modules/Registration/FEM/include/itkFEMRegistrationFilter.h @@ -191,7 +191,7 @@ class ITK_TEMPLATE_EXPORT FEMRegistrationFilter : public ImageToImageFilter