crypto: ser/de update and use nonrecoverable sig for secp256k1/r1 #7423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
joyqvq
force-pushed
the
updatefc
branch
3 times, most recently
from
1e7ce5c
to
27bea1b
Compare
joyqvq
changed the title
jonas-lj
reviewed
Jan 26, 2023
| Err(_) => return Ok(NativeResult::ok(cost, smallvec![Value::bool(false)])), | ||
| }; | ||
|
|
||
| match public_key.verify_hashed(&hashed_msg_ref, &signature) { |
There was a problem hiding this comment.
This can be simplified a bit:
let result = public_key.verify_hashed(&hashed_msg_ref, &signature).is_ok();
Ok(NativeResult::ok(cost, smallvec![Value::bool(result)]))`
jonas-lj
approved these changes
Jan 26, 2023
|
Looks good to me! |
joyqvq
commented
Jan 27, 2023
| @@ -0,0 +1,68 @@ | |||
| // Copyright (c) Mysten Labs, Inc. | |||
There was a problem hiding this comment.
moved this test to e2e since it needs to get api version to decide which signing function to use
joyqvq
commented
Jan 30, 2023
| @@ -44,7 +44,9 @@ export class Account { | |||
| async sign(data: Base64DataBuffer): Promise<SignaturePubkeyPair> { | |||
| return { | |||
| signatureScheme: this.#keypair.getKeyScheme(), | |||
| signature: this.#keypair.signData(data), | |||
| // TODO(joyqvq): Remove once 0.25.0 is released. | |||
| // This is fine to hardcode useRecoverable = false because wallet does not support Secp256k1. Ed25519 does not use this parameter. | |||
There was a problem hiding this comment.
cc @pchrysochoidis this will be removed after 0.25.0 is released
This was referenced Feb 1, 2023
williampsmith
pushed a commit
that referenced
this pull request
Feb 3, 2023
) ## What Changed - For CLI and SDK, a ECDSA k1 and r1 signature is produced using the nonrecoverable form. This means the signature is 64 bytes instead of 65. - The signature verification in sui also uses the nonrecoverable option. A valid signature should have 64 bytes. - For wallet, since only Ed25519 is supported, the secp256k1 change should not affect. - Also exposes secp256k1_verify and secp256k1_verify_recoverable API in move. - Ser/de of public keys and signatures now uses the most compact serialization with ToFromBytes. ## What Do You Need To Do - If you are using SDK to produce a Secp256k1 signature, no change is needed as long as you are using the latest version. - If you are using something else to produce a signature, your old signature will not be considered valid. You should just need to remove the last byte (65->64 bytes) to make it a valid signature again. Next: - r1 verify and verify_recoverable added in #7773
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
What Do You Need To Do
Next: