Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.19.0 rpc.discover schema or actuals bug? #7052

Closed
FrankC01 opened this issue Dec 29, 2022 · 3 comments · Fixed by #7232
Closed

0.19.0 rpc.discover schema or actuals bug? #7052

FrankC01 opened this issue Dec 29, 2022 · 3 comments · Fixed by #7232
Assignees

Comments

@FrankC01
Copy link

Is SUI RPC TransactionResponse/TransactionEffects schema wrong or ???. Here is a snippet of TransactionEffects in schema referring to ObjectRef

        "TransactionEffects": {
          "description": "The response from processing a transaction or a certified transaction",
          "type": "object",
          "required": [
            "gasObject",
            "gasUsed",
            "status",
            "transactionDigest"
          ],
          "properties": {
            "created": {
              "type": "array",
              "items": {
                "$ref": "#/components/schemas/ObjectRef"
              }
            },

With ObjectRef in schema:

        "ObjectRef": {
          "type": "object",
          "required": [
            "digest",
            "objectId",
            "version"
          ],
          "properties": {
            "digest": {
            },
            "objectId": {
            },
            "version": {
          }
        },

However, I am getting this in the subscription data:

                    "created": [
                        {
                            "owner": {"ObjectOwner": "0x dcc4acdcbe40459d37e0ff1d5518cd38705ea905"},
                            "reference": {
# Ommitted lines
                            },
                        },

Note the presence of owner in the actual data not accounted for in the schema?
I also received wrapped effect which aligns with ObjectRef expectations

                    "wrapped": [
                        {
                            "objectId": "0x 06c5428245ae9dda32ccf96d00de1fb228b09016",
                            "version": 892630,
                            "digest": "WFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFg=",
                        }
                    ],
                  ```
@awelc
Copy link
Contributor

awelc commented Dec 29, 2022

@FrankC01, thank you for filing this! As confirmed by @patrickkuo, it is indeed a bug.

@FrankC01
Copy link
Author

FrankC01 commented Jan 8, 2023

Hey gang... Is there a PR# for this?

@patrickkuo
Copy link
Contributor

Hey gang... Is there a PR# for this?

#7232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants