Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECDSA] Do not attach pubKey in account secp256k1 ECDSA tx sigs #5654

Closed
kchalkias opened this issue Oct 28, 2022 · 2 comments
Closed

[ECDSA] Do not attach pubKey in account secp256k1 ECDSA tx sigs #5654

kchalkias opened this issue Oct 28, 2022 · 2 comments
Labels
breaking change crypto Priority: High Very important task, not blocking but potentially delaying milestones or limiting our offering Stale Type: Enhancement New feature or request

Comments

@kchalkias
Copy link
Collaborator

kchalkias commented Oct 28, 2022 •
edited
Loading

Although we already use ecrecover, we can avoid sending the pk altogether and slightly reduce tx size + avoid extra serializations etc.

We should attach as sig bytes the following: flag || sig Vs flag || sig || pk. Then PK will be extracted from ecrecover Vs from subslicing the sig_bytes.

This will require some straightforward but careful engineering and it's a breaking change.
@kchalkias kchalkias added crypto Type: Enhancement New feature or request breaking change Priority: High Very important task, not blocking but potentially delaying milestones or limiting our offering labels Oct 28, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 28, 2022
@kchalkias
Copy link
Collaborator Author

Done implemented in Move, but we decided to retire ecrecover in account sigs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change crypto Priority: High Very important task, not blocking but potentially delaying milestones or limiting our offering Stale Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kchalkias