Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sui Feature Request - Minor bug with domain display in wallet #20409

Open
yjshi2015 opened this issue Nov 24, 2024 · 0 comments
Open

Sui Feature Request - Minor bug with domain display in wallet #20409

yjshi2015 opened this issue Nov 24, 2024 · 0 comments
Assignees

Comments

@yjshi2015
Copy link
Contributor

yjshi2015 commented Nov 24, 2024

Steps to Reproduce Issue

If a nickname is set first in the wallet's account and then a domain name is requested, the domain name is not automatically displayed in the wallet and there is no entry point to view the domain name(If you don't have a nickname set up you won't have this problem).

It can only be done as follows:

  1. delete the account and re-import it, but this is a very dangerous operation.

  2. Set the nickname to null value in the place of modifying the nickname, because the display priority is Nickname > Domain > Address, but this way may not be too friendly for common users.

const accountName = account?.nickname ?? domainName ?? formatAddress(account?.address || '');

Expected Result

When modifying nicknames, display the domain name, and users can choose whether to use the domain name or continue to use the nickname. like this:

image

Actual Result

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants