Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add theme dict and mimetype for radio for guiplayer service #120

Open
wants to merge 1 commit into
base: 21.02
Choose a base branch
from
Open

Add theme dict and mimetype for radio for guiplayer service #120

wants to merge 1 commit into from

Conversation

AIIX
Copy link

@AIIX AIIX commented Aug 20, 2021 •
edited
Loading

Description

  • Add support to send a dict containing the color scheme for the theme as per the figma
  • Add correct mime type for GUI Player service so it can display the correct qml

Type of PR

  • Bugfix
  • Feature implementation
  • Refactor of code (without functional changes)
  • Documentation improvements
  • Test improvements

Testing

requires: MycroftAI/plugin-playback-gui-player#3
requires: MycroftAI/skill-playback-control#49

CLA

  • Yes

This was referenced Aug 20, 2021
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
PR Processing
Status: Medium priority
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AIIX