Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate dialog #92

Open
krisgesling opened this issue Oct 28, 2021 · 7 comments
Open

Duplicate dialog #92

krisgesling opened this issue Oct 28, 2021 · 7 comments
Labels
bug Something isn't working

Comments

@krisgesling
Copy link

Describe the bug
User on the Forums is reporting that they get dialog duplicated as output:

“Successfully set thermostat to 70 none, successfully set thermostat to 70 none”

It's also reporting "None" for presumably the unit of measure.

To Reproduce
Full details here:
https://community.mycroft.ai/t/mycroft-speaks-twice-with-homeassistant-confirmations/11428/2

Expected behavior
Single dialog reported back.

@krisgesling krisgesling added the bug Something isn't working label Oct 28, 2021
@Tony763
Copy link

Tony763 commented Oct 28, 2021

Returning None should not occur with latest version. We will see if sparkyvision give us some more feedback.

I only found problem within __init__.py line 576, when HA do not return current temp. Intent get value of sensor:

File "/srv/mycroft-core/mycroft/skills/mycroft_skill/event_container.py", line 73, in wrapper
    handler(message)
  File "/opt/mycroft/skills/skill-homeassistant.mycroftai/__init__.py", line 215, in handle_sensor_intent
    self._handle_sensor(message)
  File "/opt/mycroft/skills/skill-homeassistant.mycroftai/__init__.py", line 576, in _handle_sensor
    current_temp = nice_number((float(attributes['current_temperature'])))
TypeError: float() argument must be a string or a number, not 'NoneType'

image

We will have to divide response dialogs.

@pfefferle
Copy link

We will have to divide response dialogs.

Makes sense! This was also a feedback of @krisgesling #82 (comment)

@Tony763
Copy link

Tony763 commented Oct 28, 2021

I will prepare it tonight, I will just need translations to DE.

@pfefferle
Copy link

I can help with german translations.

@Tony763
Copy link

Tony763 commented Oct 28, 2021

@pfefferle PR ready, could You add translations and test it out? Tony763:feature/issue92

@pfefferle
Copy link

@Tony763 sure, will do it later today.

@krisgesling krisgesling moved this to Work in progress by author in PR Processing Nov 2, 2021
@Tony763
Copy link

Tony763 commented Oct 15, 2022

Wow, this one ended a half way. I missed Your PR with translations.

I will try to update changes with actual code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Work in progress by author
Development

No branches or pull requests

3 participants