Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightbox start/exit animation options #346

Closed
ivanbeldad opened this issue Jun 13, 2020 · 2 comments
Closed

Lightbox start/exit animation options #346

ivanbeldad opened this issue Jun 13, 2020 · 2 comments
Labels

Comments

@ivanbeldad
Copy link

ivanbeldad commented Jun 13, 2020

What is the expected behavior?

Lightbox closes with a nice animation.

What is the current behavior?

Lightbox closes immediately, in my case using a custom item template the problem is bigger, causing flickering on the screen.

What are the steps to reproduce?

  • Install any version over 3.3.1
  • Open a lightbox and close it

Example (using an already working example from 3.3.1):
https://stackblitz.com/edit/ngx-gallery-imageviewer-dftnpz

Which versions are you using for the following packages?

Angular: 6 - 9
Angular CDK: 6 - 9
Angular CLI: 6 - 9
Typescript: 2.7 - 3.8
Gallery: 4.0.0 - 5.0.0-beta.2

@MurhafSousli
Copy link
Owner

It turned out that the animation is working properly, it just has tiny time 75ms, we are using the same Material dialog animation

https://github.com/angular/components/blob/master/src/material/dialog/dialog-animations.ts

@MurhafSousli
Copy link
Owner

I will convert this into a feature and add options to change the default start and exit times for the lightbox animation

@MurhafSousli MurhafSousli changed the title Lightbox close animation broken Lightbox start/exit animation options Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants