Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource packs window hover descriptions need own strings #2971

Closed
TechniKris opened this issue Jan 19, 2020 · 1 comment · Fixed by #3875
Closed

Resource packs window hover descriptions need own strings #2971

TechniKris opened this issue Jan 19, 2020 · 1 comment · Fixed by #3875

Comments

@TechniKris
Copy link

System Information

MultiMC version: 0.6.7-1375

Operating System: Windows 10 Home 1903 (comp. 18362.592), 64-bit

Summary of the issue or suggestion:

When you hover over a column header in the Resource packs menu, descriptions from the Loader mods menu appear, e.g. hovering over "Name" shows "The name of the mod.".

What should happen:

The text appearing should be appropriate to the Resource packs menu, e.g. hovering over "Name" should show "The name of the resource pack.".

Steps to reproduce the issue (Add more if needed):

  1. Select an instance

  2. Hit "Edit Instance" button

  3. Open "Resource packs" tab

  4. Hover over the tickboxes column, "Name", "Version" or "Last changed" header

Suspected cause:

Hover boxes use same strings as ones in the "Loader mods" menu. They should use separate strings in the code (and in turn, in translations).

Logs/Screenshots:

image

Additional Info:

The "Version" column feels mislabeled in that menu. Because resource packs, unlike mods, don't have clearly stated versions, the column's only purpose is differentating .ZIPs from folders. I think it could be renamed or maybe even removed at some point.

@peterix
Copy link
Member

peterix commented Aug 9, 2020

Yeah, the same UI control is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants