-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add setup subcommand to automate prepare-commit-msg
githook setup
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automate the setup of prepare-commit-msg githook which will append Co-authored-by trailers to the commit msg Updates typos and mistakes in the CLI help information
Also add additional test for prepare-commit-msg local hook
Extract and update manual setup documentation
Its not used on windows
Make setup integration tests work on windows This is testable on windows because it looks for USERPROFILE env first before invoking the SHGetKnownFolderPath function with FOLDERID_Profile
prepare-commit-msg
githook setup
Mubashwer
added a commit
that referenced
this pull request
Apr 7, 2024
CARGO_INCREMENTAL=0 was producing incorrect test coverage for setup.rs in #58
2c1d4c2
to
233404a
Compare
It looks like there is a bug with the way the coverage for |
Use cargo-llvm-cov instead of grcov The trade-off is that this will count unit tests as part of coverage at this moment
This was referenced Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add
git mob setup --global
command to automate the setup ofprepare-commit-msg
global githook which will append Co-authored-by trailers to the commit msgAdd
git mob setup --local
command to set up localprepare-commit-msg
githook which invokes the global one. This is for some repos ovreride localcore.hooksPath
git config variable (e.g when using husky). Global githook will not workComment-out adding of JIRA prefix to commit messages in
prepare-commist-msg
global githookUpdate README with instructions for automatic setup
Updates typos and mistakes in the CLI help information
Fix some pre-existing Clippy warnings
Replace
grcov
withcargo-llvm-cov
to generate test coveragesrc/commands/setup.rs
withgrcov