Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support array validation #40

Merged
merged 3 commits into from
Feb 2, 2018
Merged

Conversation

icepeng
Copy link
Contributor

@icepeng icepeng commented Feb 1, 2018

This change includes some additional type info, and tests.

There are no changes in logic since value.length works same between string and array.

@MrWolfZ
Copy link
Owner

MrWolfZ commented Feb 2, 2018

Thanks for this PR. From the code side there is absolutely nothing I think needs changing. What's missing is an update to the user guide, specifically the validation docs to mention the new capabilities.

@icepeng
Copy link
Contributor Author

icepeng commented Feb 2, 2018

Ok. Is it possible to add commits in pull request? Or I have to open another one?

@MrWolfZ
Copy link
Owner

MrWolfZ commented Feb 2, 2018

You can easily push other commits. Github mentions it right here:

"Add more commits by pushing to the array-validation branch on icepeng/ngrx-forms."

@MrWolfZ
Copy link
Owner

MrWolfZ commented Feb 2, 2018

Alright, then one last thing: please target the develop branch instead of master with this PR.

@icepeng
Copy link
Contributor Author

icepeng commented Feb 2, 2018

Ah, it works well. Since I am not friendly at English (I'm living in Korea) - there would be some grammar errors.

@icepeng icepeng changed the base branch from master to develop February 2, 2018 07:49
@icepeng
Copy link
Contributor Author

icepeng commented Feb 2, 2018

Ohh. Fixed target branch.

@MrWolfZ
Copy link
Owner

MrWolfZ commented Feb 2, 2018

No worries, there are no grammar errors or typos I could spot.

I just noticed one more thing though: The inline documentation for the validation functions also needs to be adjusted, e.g. this line needs to mention arrays now as well (same for other functions).

@icepeng
Copy link
Contributor Author

icepeng commented Feb 2, 2018

Updated, it would be better to merge last two commits.

@MrWolfZ
Copy link
Owner

MrWolfZ commented Feb 2, 2018

Merging the commits is not required in my opinion. However, you are of course free to do so if you want.

I'll be away now for about 2 hours. Afterwards I'll merge the PR.

@MrWolfZ MrWolfZ merged commit c88353a into MrWolfZ:develop Feb 2, 2018
@icepeng
Copy link
Contributor Author

icepeng commented Feb 2, 2018

Thank you for great support.

@icepeng icepeng deleted the array-validation branch February 2, 2018 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants