-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sortArray function #314
Comments
I'll gladly accept contributions if you are willing to work on this. At the same time, this seems like quite an edge case requirement and due to the composable nature of ngrx-forms you can easily build and use your own update function and reducer in your code base without having to go through the trouble of contributing it to the library. Let me know what you'd like to do. |
For now I have done that, but the very helpful |
That's a very good point that I didn't consider. After thinking on it, I'd rather not go through the trouble of making Therefore, I would prefer if you do contribute the |
Sorry not have gotten back to you. We found that we required the IDs to stay consistent, which goes against the FormArray manipulation functions already present in ngrx/forms. So even if I contributed the function, it would not help in our use case. In light of your comment in #311 that ngrx/forms is in maintenance mode, I'm closing this request. |
Please add a function similar to swap and move that takes a form array state and a comparator of FormState and sorts the form array controls.
(I will work on this if you accept the feature)
The text was updated successfully, but these errors were encountered: