Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markAsDirty on empty array not working #257

Closed
bram96 opened this issue Oct 28, 2021 · 1 comment
Closed

markAsDirty on empty array not working #257

bram96 opened this issue Oct 28, 2021 · 1 comment
Labels

Comments

@bram96
Copy link

bram96 commented Oct 28, 2021

Describe the bug
markAsDirty doesn't work on an empty array. In my code I do have an array that can become empty on user changes and I want to mark that property of the form as dirty. This is not working if the array is already empty, but if it is marked as dirty before the setValue it stays dirty.

The same applies for markAsTouched

To Reproduce
Steps to reproduce the behavior:
See form.reducer.ts in the example at https://codesandbox.io/s/ngrx-forms-issue-template-forked-9u9we

Expected behavior
I would expect both lines in my example to work the same

Library version:
6.3.4

@bram96 bram96 added the bug label Oct 28, 2021
@MrWolfZ
Copy link
Owner

MrWolfZ commented Nov 17, 2021

Thank you for this bug report and apologies for the delay. This issue is fixed in v6.3.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants