Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictionnary replace when not in tag ? #4

Closed
Hadrien-DELAITRE opened this issue Jun 27, 2016 · 2 comments
Closed

Dictionnary replace when not in tag ? #4

Hadrien-DELAITRE opened this issue Jun 27, 2016 · 2 comments

Comments

@Hadrien-DELAITRE
Copy link
Contributor

Why are you replacing string when it's not a tag :
https://github.com/MrSwitch/esi/blob/master/src/esi.js#L70

In my htmlString, I have other script containing such characters as :
function _callee$(_context) {.
They are replaced by : function _callee {.

Obviously when my page is served client side, javascript fails.

@MrSwitch
Copy link
Owner

If you want to remove that. Check the test script is successful. Then create a PR.
Thanks

@MrSwitch
Copy link
Owner

Thanks, just released npm i esi@* --save-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants