✅ should check returned error before deferring

MrMarble · Jul 25, 2020 · 345e92d · 345e92d
1 parent be18110
commit 345e92d
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/docker.go b/docker.go
@@ -85,7 +85,12 @@ func (d *Docker) logs(containerID string, tail string) ([]string, error) {
 		log.Fatal().Str("module", "docker").Str("containerID", containerID).Err(err).Msg("error getting container logs")
 		return nil, err
 	}
-	defer logsReader.Close()
+	defer func() {
+		err := logsReader.Close()
+		if err != nil {
+			log.Fatal().Str("module", "docker").Str("containerID", containerID).Err(err).Msg("error closing io.Reader")
+		}
+	}()
 
 	for {
 		numBytes, err := logsReader.Read(bytes)