Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot update - switch to monthly? #743

Closed
patjouk opened this issue Mar 9, 2020 · 5 comments
Closed

Dependabot update - switch to monthly? #743

patjouk opened this issue Mar 9, 2020 · 5 comments
Assignees
Labels
Milestone

Comments

@patjouk
Copy link
Contributor

patjouk commented Mar 9, 2020

We're lagging a bit behind, maybe it's time to consider moving dependabot to monthly updates instead of weekly ones. We would still get GitHub notifications for security updates and it will be easy to open them from there.

Opinions @cadecairos @Pomax @mmmavis

@patjouk patjouk added the devops label Mar 9, 2020
@Pomax
Copy link
Contributor

Pomax commented Mar 9, 2020

I don't think the issue is so much that it's frequent, but that there's single PRs for every single thing that got updated, and every PR that is reviewed good then invalidates every other PR. Doing that monthly would probably still be a very long time of pressing merge, waiting for CI to pass on the next item, pressing merge again, and all the while other people can't really land code because each merge invalidates their PRs as well. It might be a good idea to have a look at whether there's a way to have dependabot PRs that pass CI get auto-aggregated (that might be something we have to request over on the dependabot issue tracker), so that 10 PRs that all update things that don't affect each other can be landed as a single PR without blocking everyone's ability to get "real" changes landed.

@mmmavis
Copy link

mmmavis commented Mar 9, 2020

Agreed with what @Pomax said.

Also wondering if we could adjust the frequency from weekly to bi-weekly for the time being.

@cadecairos
Copy link
Contributor

Doing updates individually is something we probably want to keep, since it can surface issues related to a specific change.

The real issue we have is that piplock files are implemented foolishly and constantly cause merge issues when software unrelated to the actuall version bump get incremented (looking at you boto3)

@Pomax
Copy link
Contributor

Pomax commented Mar 9, 2020

That's part 2 of the real issue, but from a dev side, the real issue is that it easily takes an hour to merge 10 dependabot PRs that all pass CI, because every PR gets rebased and CI has to rerun after every merge into master. And not just for the person doing them, but also for everyone else whose "green" PRs keep turning "out of date" with every dependency bump merge, too.

@cadecairos cadecairos added this to the Mar 23 milestone Mar 11, 2020
@patjouk patjouk modified the milestones: Mar 23, Apr 6 Mar 23, 2020
@patjouk
Copy link
Contributor Author

patjouk commented Mar 25, 2020

Let's see how mergify is helping. If dependabot is still eating too much of our time, I'll reopen this ticket and investigate again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants