Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar isn't visible on opportunity pages with children #830

Closed
alanmoo opened this issue Oct 6, 2017 · 17 comments
Closed

Sidebar isn't visible on opportunity pages with children #830

alanmoo opened this issue Oct 6, 2017 · 17 comments
Labels

Comments

@alanmoo
Copy link
Contributor

alanmoo commented Oct 6, 2017

https://network.mozilla.org/opportunity/2017-tech-policy-fellows/

@gvn
Copy link
Contributor

gvn commented Oct 6, 2017

Ok, this is completely baffling me.

The sidebar shows up in Firefox but not in Chrome or via a curl request. I even tried creating a new parent and subpage to see if Firefox had a cached copy and the result is the same.

Since this is generated on the server the only thing I can think of is user agent causing variances in the rendered HTML...but I have no idea why that would be the case.

@alanmoo
Copy link
Contributor Author

alanmoo commented Oct 6, 2017

Can you spoof the UA in Chrome and see if it does anything?

@gvn
Copy link
Contributor

gvn commented Oct 6, 2017

Changing UA to Firefox in Safari and Chrome didn't render the sidebar. Not surprised...

Also, this doesn't repro when I run the site locally.

@gvn
Copy link
Contributor

gvn commented Oct 9, 2017

Sidebar is now showing up on staging. I can't see anything in the last 2 commits that might have fixed this, but maybe a prod push will take care of things...

@gvn
Copy link
Contributor

gvn commented Oct 12, 2017

Ok, this has to be an environment variance issue.

Staging and prod are running identical code now and still only prod has this issue.

See:
https://network.mozilla.org/opportunity/test-parent/
versus
https://network.mofostaging.net/opportunity/test-parent/
in any non-FF browser

I also can't repro the issue locally.

@gvn
Copy link
Contributor

gvn commented Oct 12, 2017

@cadecairos Is there any way to generate a diff on network-api/app/networkapi/templates/pages/landingpage.html between our current production and staging builds?

@xmatthewx
Copy link
Contributor

xmatthewx commented Jan 9, 2018

We're going to have a few new users of this multipage feature soon-ish. So good to dig into this.

@alanmoo
Copy link
Contributor Author

alanmoo commented Jan 9, 2018

I...think it works now?

@taisdesouzalessa
Copy link
Contributor

Hey @alanmoo, the menu is sill not displaying in prod site - iPhone 7 (Firefox and Safari) - not sure about other phones, though.

@alanmoo
Copy link
Contributor Author

alanmoo commented Jan 10, 2018

The plot thickens. On desktop I see the sidebar...unless private browsing is turned on.

@alanmoo
Copy link
Contributor Author

alanmoo commented Jan 10, 2018

AHA! It doesn't show in private browsing because you're not logged in. I tested across devices/browsers and is indeed the issue: The secondary menu only appears if you're logged in to the back-end of Mezzanine. Let's make that not happen, and we'll be good across all these cases.

@taisdesouzalessa
Copy link
Contributor

Mystery solved then? That was a good one!

@gideonthomas gideonthomas assigned gideonthomas and unassigned gvn Jan 15, 2018
@Pomax
Copy link
Contributor

Pomax commented Jan 19, 2018

Are there steps to ensure an opportunity page when starting with a fresh clone?

@alanmoo
Copy link
Contributor Author

alanmoo commented Jan 19, 2018

I believe the PR that just landed this week should do it. python manage.py load_fake_data (See readme)

@alanmoo
Copy link
Contributor Author

alanmoo commented Jan 23, 2018

This has been resolved. Turns out it was the "published" vs "draft" status of the main Opportunity page causing problems. It has to be in Published mode.

@alanmoo alanmoo closed this as completed Jan 23, 2018
@Pomax
Copy link
Contributor

Pomax commented Jan 23, 2018

I am actually reopening this until we have issues filed to address where to find the information we uncovered, so this "never happens again" =)

@Pomax
Copy link
Contributor

Pomax commented Jan 23, 2018

Follow up:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants